Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for supporting guest_token cookie. #195

Merged
merged 1 commit into from
Jun 15, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion config/initializers/spree.rb

This file was deleted.

6 changes: 6 additions & 0 deletions config/initializers/warden_after_auth_hook.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Merges users orders to their account after sign in and sign up.
Warden::Manager.after_set_user except: :fetch do |user, auth, opts|
if auth.cookies.signed[:guest_token].present?
Spree::Order.where(guest_token: auth.cookies.signed[:guest_token]).update_all(user_id: user.id)
end
end
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def skip_state_validation?
end

def check_authorization
authorize!(:edit, current_order, session[:access_token])
authorize!(:edit, current_order, cookies.signed[:guest_token])
end

# Introduces a registration step whenever the +registration_step+ preference is true.
Expand All @@ -47,6 +47,6 @@ def check_registration
# are redirected to the tokenized order url unless authenticated as a registered user.
def completion_route
return order_path(@order) if spree_current_user
spree.token_order_path(@order, @order.token)
spree.token_order_path(@order, @order.guest_token)
end
end
4 changes: 2 additions & 2 deletions lib/controllers/frontend/spree/orders_controller_decorator.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@

private
def check_authorization
session[:access_token] = params[:token] if params[:token]
cookies.permanent.signed[:guest_token] = params[:token] if params[:token]
order = Spree::Order.find_by_number(params[:id]) || current_order

if order
authorize! :edit, order, session[:access_token]
authorize! :edit, order, cookies.signed[:guest_token]
else
authorize! :create, Spree::Order.new
end
Expand Down
13 changes: 8 additions & 5 deletions spec/controllers/spree/checkout_controller_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,12 @@

context 'with a token' do
before do
order.stub token: 'ABC'
order.stub guest_token: 'ABC'
end

it 'redirect to the tokenized order view' do
spree_post :update, { state: 'confirm' }, { access_token: 'ABC' }
request.cookie_jar.signed[:guest_token] = 'ABC'
spree_post :update, { state: 'confirm' }
expect(response).to redirect_to spree.token_order_path(order, 'ABC')
expect(flash.notice).to eq Spree.t(:order_processed_successfully)
end
Expand All @@ -88,7 +89,7 @@
before do
controller.stub spree_current_user: user
order.stub user: user
order.stub token: nil
order.stub guest_token: nil
end

it 'redirect to the standard order view' do
Expand All @@ -108,7 +109,8 @@

it 'check if the user is authorized for :edit' do
controller.should_receive(:authorize!).with(:edit, order, token)
spree_get :registration, {}, { access_token: token }
request.cookie_jar.signed[:guest_token] = token
spree_get :registration, {}
end
end

Expand Down Expand Up @@ -137,9 +139,10 @@
end

it 'check if the user is authorized for :edit' do
request.cookie_jar.signed[:guest_token] = token
order.stub update_attributes: true
controller.should_receive(:authorize!).with(:edit, order, token)
spree_put :update_registration, { order: { email: 'jobs@spreecommerce.com' } }, { access_token: token }
spree_put :update_registration, { order: { email: 'jobs@spreecommerce.com' } }
end
end
end
7 changes: 0 additions & 7 deletions spec/models/order_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,4 @@
expect(order.user).not_to eq guest_user
end
end

context '#create' do
it 'create a token permission' do
order.save
expect(order.token).not_to be_nil
end
end
end