Feature/boostrap classes for stripe errors #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, we leave the original "error" class addition to the field itself intact. So that peoples CSS won't break.
This will render it with the boostrap "alert" styles.
|
Turns out the CI has the same trouble with running the tests as I do. |
|
I've rebased on #239 so that the CI can run the tests on this PR. |
damianlegawiec
added a commit
that referenced
this pull request
Feb 10, 2016
…pe_errors Feature/boostrap classes for stripe errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some classes to the Stripe partial, which hook into the boostrap styles for rendering errors.
After the styles are added, the form looks something like:
I failed to run the tests, somehow the Bundle was conflicting, possibly a conflict in rbenv. However, this is only JS, and as far as I can see, this is not tested anyway.