Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set asset_host to heroku url if heroku app name available #140

Merged
merged 3 commits into from
Jul 2, 2017

Conversation

krzysiek1507
Copy link
Contributor

No description provided.

@krzysiek1507 krzysiek1507 temporarily deployed to spark-starter-kit-pr-140 June 17, 2017 12:17 Inactive
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Error: The Style/DeprecatedHashMethods cop has been renamed to Style/Prefe...</summary><pre>Error: The Style/DeprecatedHashMethodscop has been renamed toStyle/PreferredHashMethods`.
(obsolete configuration found in .rubocop.yml, please update it)

@krzysiek1507 krzysiek1507 temporarily deployed to spark-starter-kit-pr-140 June 17, 2017 12:24 Inactive
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Error: The Style/DeprecatedHashMethods cop has been renamed to Style/Prefe...</summary><pre>Error: The Style/DeprecatedHashMethodscop has been renamed toStyle/PreferredHashMethods`.
(obsolete configuration found in .rubocop.yml, please update it)

Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Error: The Style/DeprecatedHashMethods cop has been renamed to Style/Prefe...</summary><pre>Error: The Style/DeprecatedHashMethodscop has been renamed toStyle/PreferredHashMethods`.
(obsolete configuration found in .rubocop.yml, please update it)

@krzysiek1507 krzysiek1507 temporarily deployed to spark-starter-kit-pr-140 June 17, 2017 12:25 Inactive
@krzysiek1507 krzysiek1507 temporarily deployed to spark-starter-kit-pr-140 June 17, 2017 12:28 Inactive
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Error: The Style/DeprecatedHashMethods cop has been renamed to Style/Prefe...</summary><pre>Error: The Style/DeprecatedHashMethodscop has been renamed toStyle/PreferredHashMethods`.
(obsolete configuration found in .rubocop.yml, please update it)

@krzysiek1507 krzysiek1507 temporarily deployed to spark-starter-kit-pr-140 June 17, 2017 12:30 Inactive
@damianlegawiec damianlegawiec mentioned this pull request Jun 17, 2017
5 tasks
@krzysiek1507 krzysiek1507 changed the title set asset_host to heroku url if heroku app name available [WIP] set asset_host to heroku url if heroku app name available Jun 17, 2017
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Error: The Style/DeprecatedHashMethods cop has been renamed to Style/Prefe...</summary><pre>Error: The Style/DeprecatedHashMethodscop has been renamed toStyle/PreferredHashMethods`.
(obsolete configuration found in .rubocop.yml, please update it)

@krzysiek1507 krzysiek1507 temporarily deployed to spark-starter-kit-pr-140 June 17, 2017 12:49 Inactive
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Error: The Style/DeprecatedHashMethods cop has been renamed to Style/Prefe...</summary><pre>Error: The Style/DeprecatedHashMethodscop has been renamed toStyle/PreferredHashMethods`.
(obsolete configuration found in .rubocop.yml, please update it)

@krzysiek1507 krzysiek1507 temporarily deployed to spark-starter-kit-pr-140 June 17, 2017 12:52 Inactive
@krzysiek1507 krzysiek1507 changed the title [WIP] set asset_host to heroku url if heroku app name available set asset_host to heroku url if heroku app name available Jun 17, 2017
@krzysiek1507 krzysiek1507 temporarily deployed to spark-starter-kit-pr-140 June 17, 2017 12:55 Inactive
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Error: The Style/DeprecatedHashMethods cop has been renamed to Style/Prefe...</summary><pre>Error: The Style/DeprecatedHashMethodscop has been renamed toStyle/PreferredHashMethods`.
(obsolete configuration found in .rubocop.yml, please update it)

@krzysiek1507 krzysiek1507 changed the title set asset_host to heroku url if heroku app name available [WIP] set asset_host to heroku url if heroku app name available Jun 17, 2017
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Error: The Style/DeprecatedHashMethods cop has been renamed to Style/Prefe...</summary><pre>Error: The Style/DeprecatedHashMethodscop has been renamed toStyle/PreferredHashMethods`.
(obsolete configuration found in .rubocop.yml, please update it)

@krzysiek1507 krzysiek1507 changed the title [WIP] set asset_host to heroku url if heroku app name available set asset_host to heroku url if heroku app name available Jun 17, 2017
@damianlegawiec damianlegawiec merged commit 2bd8b65 into master Jul 2, 2017
@damianlegawiec damianlegawiec deleted the fix/review-apps-cnd branch August 4, 2017 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants