Skip to content
This repository has been archived by the owner on Jul 9, 2022. It is now read-only.

This PR adds spring-cloud-app-starter-metadata-gradle-plugin #22

Closed
wants to merge 3 commits into from

Conversation

jvmlet
Copy link

@jvmlet jvmlet commented Feb 1, 2018

Gradle plugin to aggregate the spring metadata

Resolves #19

@sobychacko
Copy link
Contributor

Hi, @jvmlet Thank you for this PR. It looks like you are building a Spring Cloud Stream app and are using gradle as the build system. I suppose that's where the requirement for the gradle plugin came up. Did you not use the app generator or docs plugin in the project since you directly created the app? We need to decide if this is the right home for the plugin as this only contains maven plugins (so far). Could you add an integration test that somehow verifies that the metadata is generated from a real spring boot app using this plugin?

@jvmlet
Copy link
Author

jvmlet commented Feb 12, 2018

@sobychacko , I was explicitely advised by @sabbyanandan to add the gradle plugin to this repo (see comments in #19 )
The integration test is also there (see test directory)

@jvmlet
Copy link
Author

jvmlet commented Feb 12, 2018

src/test/resources/testProject simulates the real spring boot app.

@sabbyanandan sabbyanandan added this to the 2.0.0.M1 milestone Mar 25, 2018
@sobychacko
Copy link
Contributor

@jvmlet Sorry for the delay in merging this PR. I am about to merge this, but all the classes are missing copyright notice, author tag etc. Could you add those? Also, there are a few unused imports and imports with *. Please clean them up as well. Then its ready for merging upstream. Thanks.

@jvmlet
Copy link
Author

jvmlet commented Mar 28, 2018

Sure, I'll be able to accomplish this nearest Monday

@jvmlet
Copy link
Author

jvmlet commented Apr 2, 2018

@sobychacko , I've added the copyrigths and cleaned the imports.

@sobychacko
Copy link
Contributor

LGTM - polished, squashed the commit and merged upstream.
Thank you for the PR @jvmlet. Next step is to create a CI plan and a snapshot build for the plugin. If you see a pressing need for that, please raise an issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants