Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

Issue 553: AWS region should be retrieved considering multiple strategies. #559

Conversation

giova333
Copy link
Contributor

Currently, spring cloud aws uses Ec2MetadataRegionProvider for dynamic region lookup.
However, this solution doesn't work in some cases such #553
We should consider using com.amazonaws.regions.DefaultAwsRegionProviderChain that provides multiple strategies for the region lookup

…dering multiple strategies and using `DefaultAwsRegionProviderChain`
@maciejwalkowiak
Copy link
Contributor

Thanks @giova333 for PR. I am working on the same issue at exactly same time with a bit different approach as we cannot break backward compatibility at this stage. I appreciate your efforts - give me some time to mark issues as "ideal-to-contribution" and then you could pick them up.

@giova333
Copy link
Contributor Author

giova333 commented May 31, 2020

@maciejwalkowiak Sure, no problem.
I think it should be backward compatible as a new RegionProvider is still using ec2 metadata service in addition to env variables, system properties, and profile.
Anyway, take your time to deal with all existing issues

maciejwalkowiak added a commit to maciejwalkowiak/spring-cloud-aws that referenced this pull request May 31, 2020
maciejwalkowiak added a commit to maciejwalkowiak/spring-cloud-aws that referenced this pull request May 31, 2020
maciejwalkowiak added a commit to maciejwalkowiak/spring-cloud-aws that referenced this pull request May 31, 2020
@maciejwalkowiak
Copy link
Contributor

@giova333 this is a change I had in mind #560

@giova333
Copy link
Contributor Author

@maciejwalkowiak Looks good. The idea to enable DefaultAwsRegionProviderChain via property is great. I think in the major release it should be enabled by default.

@maciejwalkowiak
Copy link
Contributor

Yes I believe so too 👍 Either in 2.3 or 3.0 default chains for both credentials and regions will be used unless static values are provided.

maciejwalkowiak added a commit that referenced this pull request May 31, 2020
tmnuwan12 pushed a commit to tmnuwan12/spring-cloud-aws that referenced this pull request Jun 7, 2020
maciejwalkowiak added a commit to maciejwalkowiak/spring-cloud-aws that referenced this pull request Oct 15, 2020
maciejwalkowiak added a commit to maciejwalkowiak/spring-cloud-aws that referenced this pull request Oct 15, 2020
maciejwalkowiak added a commit to maciejwalkowiak/spring-cloud-aws that referenced this pull request Oct 15, 2020
maciejwalkowiak added a commit to maciejwalkowiak/spring-cloud-aws that referenced this pull request Oct 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

3 participants