Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

Add checkstyle file to the project #15

Closed
viniciusccarvalho opened this issue May 24, 2017 · 2 comments · Fixed by #55
Closed

Add checkstyle file to the project #15

viniciusccarvalho opened this issue May 24, 2017 · 2 comments · Fixed by #55
Assignees
@viniciusccarvalho

Comments

@viniciusccarvalho
Copy link
Contributor

No description provided.

@viniciusccarvalho viniciusccarvalho self-assigned this May 24, 2017
@joaoandremartins
Copy link
Contributor

I'm trying to enable eclipse-code-formatter following these instructions, but the Eclipse Code Formatter Plugin is clashing with another plugin I've got installed, which I don't want to uninstall.

I filed an issue in the plugin's Github page, but I'm not sure it's going to be resolved. Would be cool to have a Spring format file that I could use.

@viniciusccarvalho
Copy link
Contributor Author

We unfortunately use that file as the base for our formatting rules. I never had issues with the plugin before, so I can't really help there, I'm sorry.

I don't know if I can export Intellij format options after importing the eclipse format file, let me check that.

viniciusccarvalho added a commit to viniciusccarvalho/spring-cloud-gcp that referenced this issue Jun 1, 2017
@viniciusccarvalho
Add code formatting rules
f8a4915 
- new etc/ folder with eclipse code formatter and checkstyle rules
- refactoring of classes where import order / copyright were not
  following spec
- adding section on readme on how to enable eclipse code formatter
- fixes spring-attic#15
@viniciusccarvalho viniciusccarvalho mentioned this issue Jun 1, 2017
Closed
joaoandremartins pushed a commit that referenced this issue Jun 8, 2017
@viniciusccarvalho @joaoandremartins
Add code formatting rules
90355e8 
- new etc/ folder with eclipse code formatter and checkstyle rules
- refactoring of classes where import order / copyright were not
  following spec
- adding section on readme on how to enable eclipse code formatter
- deleted rule recommending usage of AssertJ in detriment of Junit.
- fixes #15
@joaoandremartins joaoandremartins mentioned this issue Jun 8, 2017
Merged
joaoandremartins added a commit that referenced this issue Jun 9, 2017
@joaoandremartins
Add code formatting rules (#55)
89434c2 
- new src/ folder with eclipse code formatter and checkstyle rules
- refactoring of classes where import order / copyright were not
  following spec
- adding section on CONTRIBUTING on how to enable eclipse code formatter
- deleted rule recommending usage of AssertJ in detriment of Junit.
- fixes #15
joaoandremartins added a commit that referenced this issue Jun 9, 2017
@joaoandremartins
Add code formatting rules (#55)
8e206b4 
- new src/ folder with eclipse code formatter and checkstyle rules
- refactoring of classes where import order / copyright were not
  following spec
- adding section on CONTRIBUTING on how to enable eclipse code formatter
- deleted rule recommending usage of AssertJ in detriment of Junit.
- fixes #15
joaoandremartins added a commit that referenced this issue Jun 9, 2017
@joaoandremartins
Add code formatting rules (#55)
ed560b8 
- new src/ folder with eclipse code formatter and checkstyle rules
- refactoring of classes where import order / copyright were not
  following spec
- adding section on CONTRIBUTING on how to enable eclipse code formatter
- deleted rule recommending usage of AssertJ in detriment of Junit.
- fixes #15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@viniciusccarvalho viniciusccarvalho

Labels
None yet
Milestone
No milestone
2 participants
@viniciusccarvalho @joaoandremartins