This repository has been archived by the owner on Apr 20, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 175
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixes for minor defects with Jenkins flavor of the pipeline (#148)
* Improve support for Git SSH key with local Jenkins The jenkins/start.sh now recognizes option -key <path_to_private_key> and uses it to create the SSH Git credentials when starting new local Jenkins instance for the first time. The #137 is fixed by adding missed argument to the jenkins/Dockerfile. Also the documentation now reflects the additional parameter to start.sh * Fix #134 by using OS-specific file path separator * Fix #138 by encapsulating SCM config in one place Added a unit test to reproduce the issue and refactored logic in the jenkins_pipeline_sample.groovy to use the new extension function to configure SCM block for all jobs. * Fix #141 Fixed typos in the marker of the end of the K8S block for removal. Fixed pipeline tests to not assume existence of either K8S or CF scripts. Fixed JobScripts tests to only verify availability of the CF/K8S jobs in case of them not being excluded during the customization. * Convert the code in fixes to be type-safe
- Loading branch information
1 parent
fedec2c
commit ee405c7
Showing
15 changed files
with
208 additions
and
168 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
test: | ||
services: | ||
- type: broker | ||
name: rabbitmq-github-webhook | ||
broker: foo | ||
plan: bar | ||
- type: broker | ||
name: mysql-github-webhook | ||
broker: foo | ||
plan: bar | ||
- type: app | ||
name: eureka-github-webhook | ||
coordinates: com.example.eureka:github-eureka:0.0.1.M1 | ||
- type: stubrunner | ||
name: stubrunner | ||
coordinates: com.example.github:github-analytics-stub-runner-boot-classpath-stubs:0.0.1.M1 | ||
pathToManifest: foo/manifest.yml | ||
stage: | ||
services: | ||
- type: broker | ||
name: github-rabbitmq | ||
broker: foo | ||
plan: bar | ||
- type: broker | ||
name: mysql-github | ||
broker: foo | ||
plan: bar | ||
- type: app | ||
name: github-eureka | ||
coordinates: com.example.eureka:github-eureka:0.0.1.M1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.