Skip to content

Commit

Permalink
URL Cleanup
Browse files Browse the repository at this point in the history 
This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener).

# Fixed URLs

## Fixed But Review Recommended
These URLs were fixed, but the https status was not OK. However, the https status was the same as the http request or http redirected to an https URL, so they were migrated. Your review is recommended.

* [ ] http://192.168.1.238:32248/v2/catalog (AnnotatedConnectException) with 1 occurrences migrated to:
  https://192.168.1.238:32248/v2/catalog ([https](https://192.168.1.238:32248/v2/catalog) result ConnectTimeoutException).
* [ ] http://192.168.99.100:31742 (ConnectTimeoutException) with 1 occurrences migrated to:
  https://192.168.99.100:31742 ([https](https://192.168.99.100:31742) result ConnectTimeoutException).
* [ ] http://192.168.99.100:31742/v2/catalog (ConnectTimeoutException) with 1 occurrences migrated to:
  https://192.168.99.100:31742/v2/catalog ([https](https://192.168.99.100:31742/v2/catalog) result ConnectTimeoutException).
* [ ] http://bookstore-broker.bookstore-broker.svc.cluster.local (UnknownHostException) with 2 occurrences migrated to:
  https://bookstore-broker.bookstore-broker.svc.cluster.local ([https](https://bookstore-broker.bookstore-broker.svc.cluster.local) result UnknownHostException).

## Fixed Success
These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended.

* [ ] http://example.com with 1 occurrences migrated to:
  https://example.com ([https](https://example.com) result 200).
* [ ] http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html with 2 occurrences migrated to:
  https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html ([https](https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html) result 200).
* [ ] http://contributor-covenant.org with 1 occurrences migrated to:
  https://contributor-covenant.org ([https](https://contributor-covenant.org) result 301).
* [ ] http://contributor-covenant.org/version/1/3/0/ with 1 occurrences migrated to:
  https://contributor-covenant.org/version/1/3/0/ ([https](https://contributor-covenant.org/version/1/3/0/) result 301).
* [ ] http://plugins.jetbrains.com/plugin/6546 with 2 occurrences migrated to:
  https://plugins.jetbrains.com/plugin/6546 ([https](https://plugins.jetbrains.com/plugin/6546) result 301).
* [ ] http://eclipse.org with 1 occurrences migrated to:
  https://eclipse.org ([https](https://eclipse.org) result 302).
* [ ] http://eclipse.org/m2e/ with 1 occurrences migrated to:
  https://eclipse.org/m2e/ ([https](https://eclipse.org/m2e/) result 302).
* [ ] http://www.springsource.com/developer/sts with 1 occurrences migrated to:
  https://www.springsource.com/developer/sts ([https](https://www.springsource.com/developer/sts) result 302).

# Ignored
These URLs were intentionally ignored.

* http://localhost:8080 with 1 occurrences
  • Loading branch information
@spring-operator
spring-operator committed Mar 20, 2019
1 parent 268f3a2 commit ad12609
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 14 deletions.
2 changes: 1 addition & 1 deletion CODE_OF_CONDUCT.adoc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,4 @@ Instances of abusive, harassing, or otherwise unacceptable behavior may be repor
All complaints will be reviewed and investigated and will result in a response that is deemed necessary and appropriate to the circumstances.
Maintainers are obligated to maintain confidentiality with regard to the reporter of an incident.

This Code of Conduct is adapted from the http://contributor-covenant.org[Contributor Covenant], version 1.3.0, available at http://contributor-covenant.org/version/1/3/0/[contributor-covenant.org/version/1/3/0/].
This Code of Conduct is adapted from the https://contributor-covenant.org[Contributor Covenant], version 1.3.0, available at https://contributor-covenant.org/version/1/3/0/[contributor-covenant.org/version/1/3/0/].
4 changes: 2 additions & 2 deletions CONTRIBUTING.adoc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ added after the original pull request but before a merge.
`eclipse-code-formatter.xml` file from the
https://raw.githubusercontent.com/spring-cloud/spring-cloud-build/master/spring-cloud-dependencies-parent/eclipse-code-formatter.xml[Spring
Cloud Build] project. If using IntelliJ, you can use the
http://plugins.jetbrains.com/plugin/6546[Eclipse Code Formatter
https://plugins.jetbrains.com/plugin/6546[Eclipse Code Formatter
Plugin] to import the same file.
* Make sure all new `.java` files to have a simple Javadoc class comment with at least an
`@author` tag identifying you, and preferably at least a paragraph on what the class is
Expand All @@ -41,7 +41,7 @@ added after the original pull request but before a merge.
* A few unit tests would help a lot as well -- someone has to do it.
* If no-one else is using your branch, please rebase it against the current master (or
other target branch in the main project).
* When writing a commit message please follow http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html[these conventions],
* When writing a commit message please follow https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html[these conventions],
if you are fixing an existing issue please add `Fixes gh-XXXX` at the end of the commit
message (where XXXX is the issue number).

10 changes: 5 additions & 5 deletions README.adoc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ Once the project is built, it can be deployed and registered to either Cloud Fou

== Working with the code
If you don't have an IDE preference we would recommend that you use
http://www.springsource.com/developer/sts[Spring Tools Suite] or
http://eclipse.org[Eclipse] when working with the code. We use the
http://eclipse.org/m2e/[m2eclipse] eclipse plugin for maven support. Other IDEs and tools
https://www.springsource.com/developer/sts[Spring Tools Suite] or
https://eclipse.org[Eclipse] when working with the code. We use the
https://eclipse.org/m2e/[m2eclipse] eclipse plugin for maven support. Other IDEs and tools
should also work without issue as long as they use Maven 3.3.3 or better.

== Contributing
Expand Down Expand Up @@ -70,7 +70,7 @@ added after the original pull request but before a merge.
`eclipse-code-formatter.xml` file from the
https://raw.githubusercontent.com/spring-cloud/spring-cloud-build/master/spring-cloud-dependencies-parent/eclipse-code-formatter.xml[Spring
Cloud Build] project. If using IntelliJ, you can use the
http://plugins.jetbrains.com/plugin/6546[Eclipse Code Formatter
https://plugins.jetbrains.com/plugin/6546[Eclipse Code Formatter
Plugin] to import the same file.
* Make sure all new `.java` files to have a simple Javadoc class comment with at least an
`@author` tag identifying you, and preferably at least a paragraph on what the class is
Expand All @@ -83,7 +83,7 @@ added after the original pull request but before a merge.
* A few unit tests would help a lot as well -- someone has to do it.
* If no-one else is using your branch, please rebase it against the current master (or
other target branch in the main project).
* When writing a commit message please follow http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html[these conventions],
* When writing a commit message please follow https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html[these conventions],
if you are fixing an existing issue please add `Fixes gh-XXXX` at the end of the commit
message (where XXXX is the issue number).

8 changes: 4 additions & 4 deletions deploy/kubernetes/README.adoc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -151,13 +151,13 @@ When using `minikube`, the following command will show the URL that can be used

----
$ minikube service bookstore-broker -n bookstore-broker --url
http://192.168.99.100:31742
https://192.168.99.100:31742
----

Use the provided URL to access the `/v2/catalog` endpoint of the service broker application:

----
$ curl http://192.168.99.100:31742/v2/catalog -u admin:supersecret
$ curl https://192.168.99.100:31742/v2/catalog -u admin:supersecret
{"services":[{"id":"bdb1be2e-360b-495c-8115-d7697f9c6a9e","name":"bookstore","description":"A simple book store service","bindable":true,"plan_updateable":false,"plans":[{"id":"b973fb78-82f3-49ef-9b8b-c1876974a6cd","name":"standard","description":"A simple book store plan","free":true}],"tags":["book-store","books","sample"]}]}
----

Expand Down Expand Up @@ -187,7 +187,7 @@ Events: <none>
Note the value of the `LoadBalancer Ingress` IP address and `NodePort` rows. Construct a URL using these two values, and use the this URL to access the `/v2/catalog` endpoint of the service broker application:

----
$ curl http://192.168.1.238:32248/v2/catalog -u admin:supersecret
$ curl https://192.168.1.238:32248/v2/catalog -u admin:supersecret
{"services":[{"id":"bdb1be2e-360b-495c-8115-d7697f9c6a9e","name":"bookstore","description":"A simple book store service","bindable":true,"plan_updateable":false,"plans":[{"id":"b973fb78-82f3-49ef-9b8b-c1876974a6cd","name":"standard","description":"A simple book store plan","free":true}],"tags":["book-store","books","sample"]}]}
----

Expand Down Expand Up @@ -237,7 +237,7 @@ Spec:
Relist Behavior: Duration
Relist Duration: 15m0s
Relist Requests: 0
URL: http://bookstore-broker.bookstore-broker.svc.cluster.local
URL: https://bookstore-broker.bookstore-broker.svc.cluster.local
Status:
Conditions:
Message: Successfully fetched catalog entries from broker.
Expand Down
2 changes: 1 addition & 1 deletion deploy/kubernetes/service-broker.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ metadata:
labels:
run: bookstore-broker
spec:
url: http://bookstore-broker.bookstore-broker.svc.cluster.local
url: https://bookstore-broker.bookstore-broker.svc.cluster.local
authInfo:
basic:
secretRef:
Expand Down
2 changes: 1 addition & 1 deletion ...d/sample/bookstore/servicebroker/service/BookstoreServiceInstanceBindingServiceTests.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public class BookstoreServiceInstanceBindingServiceTests {
private BookStoreServiceInstanceBindingService service;

private final Map<String, Object> credentials = new HashMap<String, Object>() {{
put("uri", "http://example.com");
put("uri", "https://example.com");
put("username", "testuser");
put("password", "testpassword");
}};
Expand Down

0 comments on commit ad12609

Please sign in to comment.