Added spring cloud task support #5
Conversation
| name: task | ||
|
|
||
| # For tests | ||
| logging.level.org.springframework.cloud.sleuth: DEBUG |
There was a problem hiding this comment.
probably want to add logging.level.org.springframework.cloud.task: DEBUG
|
|
||
| @Bean | ||
| ApplicationRunner myApplicationRunner(Tracer tracer) { | ||
| return args -> log.info("<ACCEPTANCE_TEST> <TRACE:{}> Hello from producer", tracer.currentSpan().context().traceId()); |
There was a problem hiding this comment.
Probably want to rename producer to myApplicationRunner
There was a problem hiding this comment.
It's fixed for producer cause I require this text to be present in the acceptance_tests module 😬
|
|
||
| @Bean | ||
| CommandLineRunner myCommandLineRunner(Tracer tracer) { | ||
| return args -> log.info("<ACCEPTANCE_TEST> <TRACE:{}> Hello from consumer", tracer.currentSpan().context().traceId()); |
There was a problem hiding this comment.
Probably want to rename consumer to myCommandLineRunner
There was a problem hiding this comment.
It's fixed for consumer cause I require this text to be present in the acceptance_tests module 😬
| @@ -0,0 +1,5 @@ | |||
| = Spring Cloud Task | |||
|
|
|||
| We're wrapping `TaskExecutionListener`s and `CommandLineRunner` and `ApplicationRunner`. | |||
There was a problem hiding this comment.
Added a TaskExecutionListener to the sample to see if I could see the output in Zipkin. I didn't see it appear. But I probably messed something up. Here are my additions: cppwfs@465a2ea
There was a problem hiding this comment.
I'll add the info to the README
|
done via 1396cf7 |
related issue spring-cloud/spring-cloud-sleuth#1903