-
Notifications
You must be signed in to change notification settings - Fork 699
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Avoid retrying on same instance (#834)
* cherry-pick switching to properties * Pass information on previous ServiceInstance to RequestContext. # Conflicts: # spring-cloud-loadbalancer/src/main/java/org/springframework/cloud/loadbalancer/blocking/retry/BlockingLoadBalancedRetryPolicy.java * Add a RoundRobinLoadBalancer implementation that avoids same service instance while retrying. * Wrap instances in ArrayList. Add tests. * Enable AvoidPreviousInstanceRoundRobinLoadBalancer by default if SpringRetry on classpath. * Fix failing tests. Add javadocs and author tags. * Fix properties. * Add documentation. * Fix docs after review. * Fix docs after review. * Handle avoiding previous instance with ServiceInstanceListSupplier in place of LoadBalancer. * Fix property name. * Change spelling.
- Loading branch information
1 parent
cbe4bb1
commit 25c1708
Showing
26 changed files
with
521 additions
and
220 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
105 changes: 0 additions & 105 deletions
105
.../main/java/org/springframework/cloud/client/loadbalancer/LoadBalancerRetryProperties.java
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 changes: 49 additions & 0 deletions
49
.../src/main/java/org/springframework/cloud/client/loadbalancer/RetryableRequestContext.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
/* | ||
* Copyright 2012-2020 the original author or authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.springframework.cloud.client.loadbalancer; | ||
|
||
import org.springframework.cloud.client.ServiceInstance; | ||
|
||
/** | ||
* A request context object that allows storing information on previously used service | ||
* instances. | ||
* | ||
* @author Olga Maciaszek-Sharma | ||
*/ | ||
public class RetryableRequestContext extends DefaultRequestContext { | ||
|
||
private final ServiceInstance previousServiceInstance; | ||
|
||
public RetryableRequestContext(ServiceInstance previousServiceInstance) { | ||
this.previousServiceInstance = previousServiceInstance; | ||
} | ||
|
||
public RetryableRequestContext(ServiceInstance previousServiceInstance, Object clientRequest) { | ||
super(clientRequest); | ||
this.previousServiceInstance = previousServiceInstance; | ||
} | ||
|
||
public RetryableRequestContext(ServiceInstance previousServiceInstance, Object clientRequest, String hint) { | ||
super(clientRequest, hint); | ||
this.previousServiceInstance = previousServiceInstance; | ||
} | ||
|
||
public ServiceInstance getPreviousServiceInstance() { | ||
return previousServiceInstance; | ||
} | ||
|
||
} |
Oops, something went wrong.