Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to AWS SDK v2 #2099

Closed
wants to merge 2 commits into from
Closed

Migrate to AWS SDK v2 #2099

wants to merge 2 commits into from

Conversation

hpoettker
Copy link
Contributor

@hpoettker hpoettker commented May 29, 2022

The PR migrates the AWS SDK from v1 to v2 and resolves #2038.

I'm quite happy with the current state but there are some open points:

  • The integration with AWS CodeCommit needs to be tested manually as the Community Edition of LocalStack does not support it.
  • AFAICT there is currently no release of Spring Cloud AWS with the v2 SDK. But this could also be addressed in a follow-up step to resolve Serving plain-text files with S3 Backend not working #1939.

pom.xml Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 29, 2022

Codecov Report

Merging #2099 (cd4662b) into main (d8f6341) will increase coverage by 0.05%.
The diff coverage is 84.84%.

@@             Coverage Diff              @@
##               main    #2099      +/-   ##
============================================
+ Coverage     77.72%   77.77%   +0.05%     
+ Complexity     1474     1473       -1     
============================================
  Files           183      183              
  Lines          5395     5381      -14     
  Branches        707      706       -1     
============================================
- Hits           4193     4185       -8     
+ Misses          935      929       -6     
  Partials        267      267              
Impacted Files Coverage Δ
...ver/config/EnvironmentRepositoryConfiguration.java 74.64% <ø> (ø)
.../server/support/GitCredentialsProviderFactory.java 87.50% <0.00%> (ø)
...erver/support/AwsCodeCommitCredentialProvider.java 82.75% <64.28%> (+0.94%) ⬆️
...entication/AwsIamClientAuthenticationProvider.java 65.21% <66.66%> (+3.67%) ⬆️
...server/environment/AwsS3EnvironmentRepository.java 89.41% <94.11%> (-0.13%) ⬇️
...server/environment/AwsClientBuilderConfigurer.java 80.00% <100.00%> (-5.72%) ⬇️
...onment/AwsParameterStoreEnvironmentRepository.java 100.00% <100.00%> (ø)
...AwsParameterStoreEnvironmentRepositoryFactory.java 100.00% <100.00%> (ø)
...environment/AwsS3EnvironmentRepositoryFactory.java 100.00% <100.00%> (ø)
...onment/AwsSecretsManagerEnvironmentRepository.java 96.15% <100.00%> (+3.42%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8f6341...cd4662b. Read the comment docs.

@hpoettker
Copy link
Contributor Author

hpoettker commented Jun 16, 2022

This PR has been superseded by #2111, I guess.

If a PR is not welcome or no help is wanted, a short comment and closing the PR would be appreciated.

I'll keep it open in case you're interested in the integration tests. I found them useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants