Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves to aws sdk v2. #2111

Merged
merged 2 commits into from Jun 16, 2022
Merged

Conversation

ryanjbaxter
Copy link
Contributor

Fixes #2038 and #2106

@ryanjbaxter ryanjbaxter linked an issue Jun 16, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #2111 (63c4bea) into main (ec4c448) will increase coverage by 0.03%.
The diff coverage is 86.20%.

@@             Coverage Diff              @@
##               main    #2111      +/-   ##
============================================
+ Coverage     77.72%   77.75%   +0.03%     
  Complexity     1474     1474              
============================================
  Files           183      183              
  Lines          5395     5390       -5     
  Branches        707      707              
============================================
- Hits           4193     4191       -2     
+ Misses          935      932       -3     
  Partials        267      267              
Impacted Files Coverage Δ
...ver/config/EnvironmentRepositoryConfiguration.java 74.64% <ø> (ø)
.../server/support/GitCredentialsProviderFactory.java 87.50% <0.00%> (ø)
...erver/support/AwsCodeCommitCredentialProvider.java 82.78% <61.53%> (+0.96%) ⬆️
...entication/AwsIamClientAuthenticationProvider.java 66.66% <87.50%> (+5.12%) ⬆️
...server/environment/AwsS3EnvironmentRepository.java 89.28% <92.85%> (-0.25%) ⬇️
...server/environment/AwsClientBuilderConfigurer.java 80.00% <100.00%> (-5.72%) ⬇️
...onment/AwsParameterStoreEnvironmentRepository.java 100.00% <100.00%> (ø)
...AwsParameterStoreEnvironmentRepositoryFactory.java 100.00% <100.00%> (ø)
...environment/AwsS3EnvironmentRepositoryFactory.java 100.00% <100.00%> (ø)
...onment/AwsSecretsManagerEnvironmentRepository.java 92.72% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec4c448...63c4bea. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Spring Vault 3.0.0-M1 awss3 integration uses AWS SDKv1, though AWS already suggest using SDKv2
3 participants