Gradle plugin - improve compatibility with Configuration Cache #1825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aSemy Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@aSemy Thank you for signing the Contributor License Agreement! |
|
hey @shanman190 , WDYT? |
|
@aSemy can you please resolve the conflicts? |
|
@marcingrzejszczak, the implementation looks good to me and is compatible with the Gradle 6.8 baseline for 3.1. Only thing that stuck out to me was the code style not following the Spring defaults, but that's minor. |
|
@aSemy can we merge this? |
|
@marcingrzejszczak definitely! |
|
Congrats @aSemy on your first contribution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid using Project during task execution
buildRootPath(), fix some Javadoc)The tests pass, but I haven't verified that the plugin is now compatible with the Gradle Configuration Cache, so I'm marking this as 'draft'.
(hopefully) fixes #1824