Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable ctr annotation build custom configuration #5368

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

klopfdreh
Copy link
Contributor

@klopfdreh klopfdreh commented Jun 5, 2023

Addresses: #4597

@klopfdreh
Copy link
Contributor Author

klopfdreh commented Jun 5, 2023

@cppwfs / @onobc - I hope this way you also can customize the bean creation otherwise the ComposedTaskRunnerConfiguration should be changed and allow to override of beans

@onobc
Copy link
Contributor

onobc commented Jun 5, 2023

@klopfdreh we truly appreciate this improvement but it will have to wait until after 2.11.0 as it is big enough of a change to warrant extra care and we are all busy focusing on what is already in scope for 2.11.0. Marking it as on-hold and we will review post 2.11.0. Thank you.

@onobc onobc added the status/on-hold For various reasons is on hold label Jun 5, 2023
@onobc onobc added this to the 2.11.x milestone Jun 5, 2023
@klopfdreh
Copy link
Contributor Author

@onobc - I guess it would be easier to redo the work at the current main branch. Let me know if the work should be done and I am going to force push a new version.

@klopfdreh
Copy link
Contributor Author

klopfdreh commented May 27, 2024

@onobc - as the 2.11.3 release is out - should I do a rework on this so that we can merge it? @Clemens-L already provided one of our customizations to the code base with: 13486fc and it would be much easier when we dont have to copy all the classes for customization anymore 😄

@cppwfs cppwfs modified the milestones: 2.11.x, 3.0.x May 28, 2024
@cppwfs
Copy link
Contributor

cppwfs commented May 28, 2024

Hello @klopfdreh,
Thanks for reaching out! Let's hold for a just a bit longer, we are about to start work on 3.x and you can migrate then. We'll be announcing this soon!

@klopfdreh
Copy link
Contributor Author

Hello @klopfdreh, Thanks for reaching out! Let's hold for a just a bit longer, we are about to start work on 3.x and you can migrate then. We'll be announcing this soon!

All right! 👍

@corneil corneil force-pushed the main branch 2 times, most recently from c0462f2 to f0fb797 Compare August 8, 2024 11:55
@cppwfs cppwfs removed this from the 3.0.x milestone Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/on-hold For various reasons is on hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants