Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage active Task Map #112

Closed
sabbyanandan opened this issue Apr 24, 2018 · 1 comment
Closed

Manage active Task Map #112

sabbyanandan opened this issue Apr 24, 2018 · 1 comment
Assignees
@tzolov
Milestone
1.3.8.RELEASE

Comments

@sabbyanandan
Copy link
Contributor

sabbyanandan commented Apr 24, 2018 •
edited

A cleanup routine would be in place to make sure the Task PIDs in the running Map doesn't grow indefinitely.

Following two items are out of scope for this issue.

We would have a separate thread to double check whether the PID is still alive; if not, we will remove it from the Map.

Also, when a cleanup/destroy routine is invoked from SCDF, we will make sure to cleanup the PID from running Map. This is already in place for Streams; we would implement it for Tasks now.
@sabbyanandan sabbyanandan added area/tests Belongs to tests ready and removed area/tests Belongs to tests labels Apr 24, 2018
@sabbyanandan sabbyanandan added this to the 1.3.5.RELEASE milestone Apr 24, 2018
@jvalkeal jvalkeal modified the milestones: 1.3.6.RELEASE, 1.3.7.RELEASE May 25, 2018
@sabbyanandan sabbyanandan assigned tzolov and unassigned markpollack Jul 10, 2018
@tzolov
Copy link
Contributor

tzolov commented Jul 11, 2018

What qualifies a Task as alive? The LaunchState defines the following states: launching, running, cancelled, complete, failed, error, unknown.
For which of them should we prune the task instance from the running map?
I guess that the launching and running should not be removed and the cancelled needs to be removed.
What about the complete, failed, error, unknown states?

@tzolov tzolov added in progress and removed ready labels Jul 11, 2018
tzolov added a commit to tzolov/spring-cloud-deployer-local that referenced this issue Jul 11, 2018
@tzolov
Prune non-recent task instance history
9910392 
 Resolves spring-cloud#112

 This solution aim to clean the history of repeatedly executed tasks. Only the last launched Task instance is kept in the running map.
 - Track the previous task-launch instance for the any given Task (identified by the Task Name)
 - On new Task launch event, find all previous task instances for the Task being launched.
 - Found instances in non-running and non-launching state are removed from the running and the tracking maps.
@tzolov tzolov mentioned this issue Jul 11, 2018
Closed
@tzolov tzolov added in pr and removed in progress labels Jul 16, 2018
@cppwfs cppwfs closed this as completed in f0fb317 Aug 15, 2018
@cppwfs cppwfs removed the in pr label Aug 15, 2018
@ilayaperumalg ilayaperumalg mentioned this issue Dec 21, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tzolov tzolov

Labels
None yet
Projects
None yet
Milestone
1.3.8.RELEASE
Development

No branches or pull requests
5 participants
@jvalkeal @markpollack @cppwfs @tzolov @sabbyanandan