Unable to set RequestRateLimiter as default filters via configuration properties

[zhaoyibo]

in Finchley.RC1, I found that I can't configure defaultFilters with RequestRateLimiter like this

default-filters:
- name: RequestRateLimiter
  args:
    burstCapacity: 2
    replenishRate: 2
    keyResolver: '#{@userKeyResolver}'

because AbstractRateLimiter#onApplicationEvent would not put the routeId and routeConfig to the config map.

	@Override
	public void onApplicationEvent(FilterArgsEvent event) {
		Map<String, Object> args = event.getArgs();

		// only defaultFilters is ok, others will return
		if (args.isEmpty() || !hasRelevantKey(args)) {
			return;
		}

		String routeId = event.getRouteId();
		C routeConfig = newConfig();
		ConfigurationUtils.bind(routeConfig, args,
				configurationPropertyName, configurationPropertyName, validator);
		getConfig().put(routeId, routeConfig);
	}
	private boolean hasRelevantKey(Map<String, Object> args) {
		return args.keySet().stream()
				.anyMatch(key -> key.startsWith(configurationPropertyName + "."));
	}

if only add RequestRateLimiter to defaultFilters, only the defaultFilters contains the key configurationPropertyName, others don't have the key so they are not in config map.

but RedisRateLimiter#isAllowed can't get the routeConfig through the specified routeId so we will get an exception.

	public Mono<Response> isAllowed(String routeId, String id) {
		if (!this.initialized.get()) {
			throw new IllegalStateException("RedisRateLimiter is not initialized");
		}
                 // the routeConfig can only be obtained when the routeId is "defaultFilters"
		Config routeConfig = getConfig().get(routeId);

		if (routeConfig == null) {
			if (defaultConfig == null) {
				throw new IllegalArgumentException("No Configuration found for route " + routeId);
			}
			routeConfig = defaultConfig;
		}
        
		// ...
	}

exception

java.lang.IllegalArgumentException: No Configuration found for route service_customer
	at org.springframework.cloud.gateway.filter.ratelimit.RedisRateLimiter.isAllowed(RedisRateLimiter.java:93) ~[spring-cloud-gateway-core-2.0.0.RC1.jar:2.0.0.RC1]

is it a bug or the designer deliberately did so?

[starslau]

I also encountered this problem, how did you solve it later?

[SoftwareKing]

@zhaoyibo 方便加你微信交流一下吗？我微信是Software_King

[spencergibb]

See here for how to configure https://github.com/spring-cloud/spring-cloud-gateway/blob/master/spring-cloud-gateway-core/src/test/resources/application-redis-rate-limiter-config.yml#L15

[zhaoyibo]

@spencergibb Yes, I have read this configuration. But this configuration is for the specified route, this can work. However, what I said is that the default-filters are not for the specified route.

[spencergibb]

It's the same, just under the default routes

[zhaoyibo]

@spencergibb But it doesn't work, cannot find configuration for route.

[spencergibb]

I see.

[keets2012]

@spencergibb have the problem been solved ?