Optimize thread safe code and replace the synchronized class "StringB…

…uffer" by an unsynchronized one "StringBuilder". (#2704)
spring-cloud · Feb 5, 2018 · 076df77 · 076df77
1 parent 07411bb
commit 076df77
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/.../main/java/org/springframework/cloud/netflix/eureka/server/EurekaDashboardProperties.java b/.../main/java/org/springframework/cloud/netflix/eureka/server/EurekaDashboardProperties.java
@@ -70,7 +70,7 @@ public int hashCode() {
 
 	@Override
 	public String toString() {
-		final StringBuffer sb = new StringBuffer("EurekaDashboardProperties{");
+		final StringBuilder sb = new StringBuilder("EurekaDashboardProperties{");
 		sb.append("path='").append(path).append('\'');
 		sb.append(", enabled=").append(enabled);
 		sb.append('}');

diff --git a/...bbon/src/main/java/org/springframework/cloud/netflix/ribbon/RibbonLoadBalancerClient.java b/...bbon/src/main/java/org/springframework/cloud/netflix/ribbon/RibbonLoadBalancerClient.java
@@ -201,7 +201,7 @@ public String getScheme() {
 
 		@Override
 		public String toString() {
-			final StringBuffer sb = new StringBuffer("RibbonServer{");
+			final StringBuilder sb = new StringBuilder("RibbonServer{");
 			sb.append("serviceId='").append(serviceId).append('\'');
 			sb.append(", server=").append(server);
 			sb.append(", secure=").append(secure);

diff --git a/.../src/main/java/org/springframework/cloud/netflix/ribbon/support/RibbonCommandContext.java b/.../src/main/java/org/springframework/cloud/netflix/ribbon/support/RibbonCommandContext.java
@@ -198,7 +198,7 @@ public int hashCode() {
 
 	@Override
 	public String toString() {
-		final StringBuffer sb = new StringBuffer("RibbonCommandContext{");
+		final StringBuilder sb = new StringBuilder("RibbonCommandContext{");
 		sb.append("serviceId='").append(serviceId).append('\'');
 		sb.append(", method='").append(method).append('\'');
 		sb.append(", uri='").append(uri).append('\'');

diff --git a/...lix-zuul/src/main/java/org/springframework/cloud/netflix/zuul/filters/ZuulProperties.java b/...lix-zuul/src/main/java/org/springframework/cloud/netflix/zuul/filters/ZuulProperties.java
@@ -529,7 +529,7 @@ public int hashCode() {
 
 		@Override
 		public String toString() {
-			final StringBuffer sb = new StringBuffer("Host{");
+			final StringBuilder sb = new StringBuilder("Host{");
 			sb.append("maxTotalConnections=").append(maxTotalConnections);
 			sb.append(", maxPerRouteConnections=").append(maxPerRouteConnections);
 			sb.append(", socketTimeoutMillis=").append(socketTimeoutMillis);
@@ -576,7 +576,7 @@ public int hashCode() {
 
 		@Override
 		public String toString() {
-			final StringBuffer sb = new StringBuffer("HystrixSemaphore{");
+			final StringBuilder sb = new StringBuilder("HystrixSemaphore{");
 			sb.append("maxSemaphores=").append(maxSemaphores);
 			sb.append('}');
 			return sb.toString();