Skip to content

Commit

Permalink
Merge pull request #1370 from tiny-dancer/master
Browse files Browse the repository at this point in the history
* pull1370:
  Warning for GC Overhead Limit Reached with servo.
  • Loading branch information
spencergibb committed Oct 11, 2016
2 parents aa16094 + 5a127d0 commit d23aa67
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions docs/src/main/asciidoc/spring-cloud-netflix.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -1758,6 +1758,18 @@ If Spring AOP is enabled and `org.aspectj:aspectjweaver` is present on your runt
3. URI, sanitized for Atlas
4. Client name

WARNING: Avoid using hardcoded url parameters within `RestTemplate`. When targeting dynamic endpoints use URL variables. This will avoid potential "GC Overhead Limit Reached" issues where `ServoMonitorCache` treats each url as a unique key.

[source,java,indent=0]
----
// recommended
String orderid = "1";
restTemplate.getForObject("http://testeurekabrixtonclient/orders/{orderid}", String.class, orderid)
// avoid
restTemplate.getForObject("http://testeurekabrixtonclient/orders/1", String.class)
----

[[netflix-metrics-spectator]]
=== Metrics Collection: Spectator

Expand Down

0 comments on commit d23aa67

Please sign in to comment.