#947 ServoMonitorCache and GC Overhead Limit Reached: Added documentation/heads up accordingly #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tiny-dancer Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@tiny-dancer Thank you for signing the Contributor License Agreement! |
tiny-dancer
changed the title
Current coverage is 73.78% (diff: 100%)@@ master #1370 diff @@
==========================================
Files 184 184
Lines 5649 5649
Methods 0 0
Messages 0 0
Branches 858 858
==========================================
+ Hits 4166 4168 +2
+ Misses 1182 1180 -2
Partials 301 301
|
spencergibb
requested changes
Oct 3, 2016
| @@ -1728,6 +1728,20 @@ If Spring AOP is enabled and `org.aspectj:aspectjweaver` is present on your runt | |||
| 3. URI, sanitized for Atlas | |||
| 4. Client name | |||
|
|
|||
| [TIP] | |||
| ==== | |||
| Don't use hardcoded url parameters within `RestTemplate'. When targeting dynamic endpoints use templated urls. This will avoid potential "GC Overhead Limit Reached" issues where `ServoMonitorCache` treats each url as a unique key. | |||
There was a problem hiding this comment.
- s/Don't use/Avoid using
- s/use templated urls/use URL variables
| [TIP] | ||
| ==== | ||
| Don't use hardcoded url parameters within `RestTemplate'. When targeting dynamic endpoints use templated urls. This will avoid potential "GC Overhead Limit Reached" issues where `ServoMonitorCache` treats each url as a unique key. | ||
| ` |
| // recommended | ||
| String orderid = "1"; | ||
| restTemplate.getForObject("http://testeurekabrixtonclient/orders/{orderid}", String.class, orderid) | ||
| ` |
| String orderid = "1"; | ||
| restTemplate.getForObject("http://testeurekabrixtonclient/orders/{orderid}", String.class, orderid) | ||
| ` | ||
| ` |
| ` | ||
| // avoid | ||
| restTemplate.getForObject("http://testeurekabrixtonclient/orders/1", String.class) | ||
| ` |
|
@spencergibb believe updates are in place accordingly |
spencergibb
added a commit
that referenced
this pull request
Oct 11, 2016
* pull1370: Warning for GC Overhead Limit Reached with servo.
|
Squashed and merged with some polish via d23aa67 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quickly put this together - wasn't able to render a local "preview". Feel free to criticize verbiage or syntax accordingly.
#947 (comment)