Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any multipart request with a boundary in the content type raises an exception #1663

Closed
eloipoch opened this issue Feb 2, 2017 · 18 comments
Closed
Labels
Milestone

Comments

@eloipoch
Copy link
Contributor

eloipoch commented Feb 2, 2017

In 1.3.0.M1 seems that a bug has been introduced.

Any multipart request that in his Content-Type adds the boundary parameter (in theory a required parameter, see RFC) raises an exception with the message "MIME type may not contain reserved characters".

I think it has been introduced in the commit which tries to handle well a content-type with a charset due to the upgrade of the httpclient library.

I will try to open a PR with a fix in order to have it for this release.

@hartmut-pq
Copy link

Hi, I've got same issues with 1.2.5.RELEASE

@spencergibb
Copy link
Member

Reopening to apply to Camden branch 1.2.x

@spencergibb spencergibb reopened this Feb 6, 2017
@hartmut-pq
Copy link

Thanks a lot!
Note: broke upgrade to spring boot 1.5.1.RELEASE & org.springframework.cloud:spring-cloud-dependencies:Camden.SR5

@spencergibb
Copy link
Member

spencergibb commented Feb 6, 2017

Here's a workaround with Camden.SR5 and Spring Boot 1.5 https://gist.github.com/spencergibb/80a134b4738c78ca64e4d0c77214fcb6

@spencergibb
Copy link
Member

Cherry picked to 1.2.x ee953be

joshiste added a commit to codecentric/spring-boot-admin that referenced this issue Feb 10, 2017
Posting via zuul doesnt work in case the Content-Type has a charset
specified.
Applied fix from spring-cloud/spring-cloud-netflix#1663

fixes #403
joshiste added a commit to joshiste/spring-boot-admin that referenced this issue Feb 10, 2017
Posting via zuul doesnt work in case the Content-Type has a charset
specified.
Applied fix from spring-cloud/spring-cloud-netflix#1663

fixes codecentric#403
@prantan7
Copy link

prantan7 commented Feb 11, 2017

From the above message it seems that the fix is done for this. However ,we tried after upgrading the boot dependencies to 1.5.1.RELEASE & spring-cloud-dependencies to Camden.SR5, it still didn't work for us.

With what versions the fix for "-MIME type may not contain reserved characters" is supposed to work

@ryanjbaxter
Copy link
Contributor

It looks like this was cherry picked after the release occurred, can your try Camden.BUILD-SNAPSHOT?

@prantan7
Copy link

prantan7 commented Feb 11, 2017

Thanks Ryan !! I will check with the SNAPSHOT version and let you know.

Is the fix available in any DALSTON version as well?

Is there any other to resolve this besides updating the dependency. I saw some messages regarding using the RibbonRoutingFilter instead of the SimpleHostRoutingFilter.

@spencergibb
Copy link
Member

Yes, it will be in Dalston RC1. The gist above is a workaround.

@hartmut-pq
Copy link

So there is no other Camden Release lined up including the fix?
I generally don't feel comfortable to work on a BUILD-SNAPSHOT...

@ryanjbaxter
Copy link
Contributor

There will be another Camden release coming soon.

@hartmut-pq
Copy link

Hi @ryanjbaxter - how soon is soon going to be? :-)

21 days ago

@ryanjbaxter
Copy link
Contributor

@hartmut-pq most likely this week, sorry for the delay

@asarkar
Copy link
Contributor

asarkar commented Mar 10, 2017

@ryanjbaxter We hit this issue today, and as a result, a multipart upload feature is busted. Do you have a definitive timeline for this to be released? I'd like to avoid upgrading to SNAPSHOT, if I can, only to upgrade to a release couple days later.

@ryanjbaxter
Copy link
Contributor

Camden.SR6 will hopefully be released today, if not Monday I would think at the latest. The Netflix 1.2.6.RELEASE which will be included in Camden.SR6 is already in Maven Central if you would like to try it out.

@asarkar
Copy link
Contributor

asarkar commented Mar 10, 2017

@ryanjbaxter Thanks for the info. Please provide an update here when the release is available and I'll go grab it.

@ryanjbaxter
Copy link
Contributor

The release is now available.

@asarkar
Copy link
Contributor

asarkar commented Mar 15, 2017

Confirmed working. Thanks @ryanjbaxter

ejavexpert added a commit to ejavexpert/java-spring-boot-admin that referenced this issue Mar 25, 2022
Posting via zuul doesnt work in case the Content-Type has a charset
specified.
Applied fix from spring-cloud/spring-cloud-netflix#1663

fixes #403
KingSize0319 added a commit to KingSize0319/spring-boot-admin that referenced this issue Feb 6, 2023
Posting via zuul doesnt work in case the Content-Type has a charset
specified.
Applied fix from spring-cloud/spring-cloud-netflix#1663

fixes #403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants