Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#947 ServoMonitorCache and GC Overhead Limit Reached: Added documentation/heads up accordingly #1370

Closed
wants to merge 7 commits into from
Closed

#947 ServoMonitorCache and GC Overhead Limit Reached: Added documentation/heads up accordingly #1370

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ee38097
#947 Added documentation/heads up accordingly
tiny-dancer Oct 2, 2016
f8d761d
updating per recommendations
tiny-dancer Oct 9, 2016
499ff65
updating per recommendations
tiny-dancer Oct 9, 2016
9c140ab
updating per recommendations
tiny-dancer Oct 9, 2016
043c044
updating per recommendations
tiny-dancer Oct 9, 2016
6f1f59f
syntax error
tiny-dancer Oct 9, 2016
a7a93e5
code highlighting
tiny-dancer Oct 9, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 14 additions & 0 deletions docs/src/main/asciidoc/spring-cloud-netflix.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1728,6 +1728,20 @@ If Spring AOP is enabled and `org.aspectj:aspectjweaver` is present on your runt
3. URI, sanitized for Atlas
4. Client name

[TIP]
====
Don't use hardcoded url parameters within `RestTemplate'. When targeting dynamic endpoints use templated urls. This will avoid potential "GC Overhead Limit Reached" issues where `ServoMonitorCache` treats each url as a unique key.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

[source,java,indent=0]
----

// recommended
String orderid = "1";
restTemplate.getForObject("http://testeurekabrixtonclient/orders/{orderid}", String.class, orderid)
`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

// avoid
restTemplate.getForObject("http://testeurekabrixtonclient/orders/1", String.class)
`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

----

====

[[netflix-metrics-spectator]]
=== Metrics Collection: Spectator

Expand Down