Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return empty list in bootstraper when discovery client disabled. #4099

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

ryanjbaxter
Copy link
Contributor

@ryanjbaxter ryanjbaxter added the bug label Jun 3, 2022
@ryanjbaxter ryanjbaxter added this to the 3.1.3 milestone Jun 3, 2022
@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #4099 (0328a66) into 3.1.x (9b6b0ab) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##              3.1.x    #4099      +/-   ##
============================================
+ Coverage     55.49%   55.53%   +0.03%     
- Complexity      524      528       +4     
============================================
  Files            58       58              
  Lines          2501     2503       +2     
  Branches        234      236       +2     
============================================
+ Hits           1388     1390       +2     
  Misses         1024     1024              
  Partials         89       89              
Impacted Files Coverage Δ
.../eureka/config/EurekaConfigServerBootstrapper.java 82.60% <100.00%> (+1.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b6b0ab...0328a66. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants