SQS Messaging Autoconfig #1218

devinsba · 2019-02-22T23:26:42Z

partially addressed #1217

Attempts to make spring-messaging generic component for use elsewhere TracingMethodMessageHandlerAdapter. I'm still thinking about how to abstract/wrap the existing classes so code doesn't have to me copied from the Impl on the other side

devinsba · 2019-02-26T20:56:54Z

@adriancole when you have a few minutes I'd appreciate feedback on the messaging model here. I'm not that familiar with it and our examples are not the most straightforward (rabbit/kafka)

codefromthecrypt

I have an alternate suggestion for SQS which will make the model look exact same as rabbit (which makes sense as both are remote brokers)

...springframework/cloud/sleuth/instrument/messaging/TraceSpringMessagingAutoConfiguration.java

...rg/springframework/cloud/sleuth/instrument/messaging/TracingMethodMessageHandlerAdapter.java

...a/org/springframework/cloud/sleuth/instrument/messaging/TraceMessagingAutoConfiguration.java

devinsba · 2019-03-03T14:35:51Z

@marcingrzejszczak I'm not sure why the test that is failing is failing. It's not in the stuff I modified so I am a bit lost. Maybe my test is not cleaning up after itself completely? Not sure

devinsba · 2019-03-03T14:36:13Z

spring-cloud-sleuth-core/pom.xml

@@ -82,6 +82,11 @@
 			<groupId>org.springframework.cloud</groupId>
 			<artifactId>spring-cloud-commons</artifactId>
 		</dependency>
+		<dependency>
+			<groupId>org.springframework.cloud</groupId>
+			<artifactId>spring-cloud-aws-messaging</artifactId>


Not sure if I should bring in the starter of just the code?

Concrete dep is ok.

marcingrzejszczak · 2019-03-04T09:50:04Z

@marcingrzejszczak I'm not sure why the test that is failing is failing. It's not in the stuff I modified so I am a bit lost. Maybe my test is not cleaning up after itself completely? Not sure

Flakey test 😭

marcingrzejszczak · 2019-03-04T09:57:18Z

@devinsba if you rebase against master, you'll see that this test is ignored :| It's been flakey for some time so I've decided not to run it (and the problem is gone ;) )

devinsba · 2019-03-04T14:06:54Z

I was going to rebase to squash all the checkstyle commits anyway so will do

codecov-io · 2019-03-04T14:22:49Z

Codecov Report

Merging #1218 into master will decrease coverage by 0.5%.
The diff coverage is 37.25%.

@@             Coverage Diff              @@
##             master    #1218      +/-   ##
============================================
- Coverage     69.39%   68.89%   -0.51%     
- Complexity      775      777       +2     
============================================
  Files           143      145       +2     
  Lines          3663     3716      +53     
  Branches        401      407       +6     
============================================
+ Hits           2542     2560      +18     
- Misses          889      924      +35     
  Partials        232      232

Impacted Files	Coverage Δ	Complexity Δ
...aging/TraceSpringIntegrationAutoConfiguration.java	`100% <ø> (ø)`	`3 <0> (-2)`	⬇️
...ssaging/TraceSpringMessagingAutoConfiguration.java	`100% <100%> (ø)`	`3 <3> (?)`
.../messaging/TracingMethodMessageHandlerAdapter.java	`15.15% <16.12%> (ø)`	`1 <1> (?)`
...ent/messaging/TraceMessagingAutoConfiguration.java	`48.41% <64.7%> (+1.68%)`	`1 <0> (ø)`	⬇️
...ing/TracingConnectionFactoryBeanPostProcessor.java	`63.93% <0%> (-8.2%)`	`6% <0%> (ø)`
...jms/config/TracingJmsListenerEndpointRegistry.java	`67.81% <0%> (+6.89%)`	`17% <0%> (ø)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9e029a...585c962. Read the comment docs.

codecov-io · 2019-03-04T14:22:49Z

Codecov Report

Merging #1218 into master will increase coverage by 0.32%.
The diff coverage is 85.45%.

@@             Coverage Diff             @@
##             master   #1218      +/-   ##
===========================================
+ Coverage     58.07%   58.4%   +0.32%     
- Complexity      802     808       +6     
===========================================
  Files           151     153       +2     
  Lines          4308    4361      +53     
  Branches        469     475       +6     
===========================================
+ Hits           2502    2547      +45     
- Misses         1592    1596       +4     
- Partials        214     218       +4

Impacted Files	Coverage Δ	Complexity Δ
...aging/TraceSpringIntegrationAutoConfiguration.java	`100% <ø> (ø)`	`3 <0> (-2)`	⬇️
...ssaging/TraceSpringMessagingAutoConfiguration.java	`100% <100%> (ø)`	`3 <3> (?)`
...ent/messaging/TraceMessagingAutoConfiguration.java	`39.71% <84.21%> (+6.92%)`	`1 <0> (ø)`	⬇️
.../messaging/TracingMethodMessageHandlerAdapter.java	`84.84% <84.84%> (ø)`	`5 <5> (?)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dbf99c...6c33937. Read the comment docs.

marcingrzejszczak

Minor suggestions. Also I think that the docs are missing, right?

.../springframework/cloud/sleuth/instrument/messaging/ITTracingMethodMessageHandlerAdapter.java

...t/java/org/springframework/cloud/sleuth/instrument/messaging/SqsQueueMessageHandlerTest.java

...rg/springframework/cloud/sleuth/instrument/messaging/TracingMethodMessageHandlerAdapter.java

devinsba · 2019-03-04T14:56:27Z

Yup, no docs yet. Only got it to a point I was confident over the weekend

devinsba · 2019-03-04T21:30:16Z

Found a large bug, please don't merge

devinsba · 2019-03-05T18:44:04Z

So it turns out it was only a bug in my slightly different internal impl for spring 4 (not boot). @marcingrzejszczak, @adriancole, @shakuzen please review when you have time

codefromthecrypt

data suggestions but even if not, looks good

docs/src/main/asciidoc/spring-cloud-sleuth.adoc

...a/org/springframework/cloud/sleuth/instrument/messaging/TraceMessagingAutoConfiguration.java

devinsba · 2019-03-08T15:21:38Z

...rg/springframework/cloud/sleuth/instrument/messaging/TracingMethodMessageHandlerAdapter.java

+	private TraceContext.Extractor<MessageHeaderAccessor> extractor;
+
+
+	TracingMethodMessageHandlerAdapter(Tracing tracing,


Having read through more of the messaging code I'm not sure how reusable this would need to be. It seems most other things will be covered by the existing spring-integration style instrumentation. I'd love to get input from maybe someone who works on that project (spring-messaging/spring-integration) on whether maybe the SQS messaging is a special case

Looking through the code I can find, this does seem to become useful for @MessageMapping and @SubscribeMapping which don't look to be covered by the current websockets instrumentation so I think it is useful to leave this here

marcingrzejszczak · 2019-03-21T11:34:04Z

Hey @devinsba, how is it going with this PR? Just FYI the build will be failing ATM due to issues with HATEOAS

marcingrzejszczak · 2019-03-29T11:49:15Z

Hey @devinsba , I've fixed the merge conflicts. What do we do about this? :P

neoshadybeat · 2019-09-03T10:05:32Z

Any updates about this PR?

spring-projects-issues added the waiting-for-triage label Feb 22, 2019

devinsba mentioned this pull request Feb 22, 2019

Add support for SQS #1217

Closed

spencergibb added enhancement and removed waiting-for-triage labels Feb 25, 2019

codefromthecrypt reviewed Feb 27, 2019

View reviewed changes

shakuzen reviewed Feb 27, 2019

View reviewed changes

...a/org/springframework/cloud/sleuth/instrument/messaging/TraceMessagingAutoConfiguration.java Outdated Show resolved Hide resolved

devinsba marked this pull request as ready for review March 3, 2019 14:32

devinsba commented Mar 3, 2019

View reviewed changes

marcingrzejszczak reviewed Mar 4, 2019

View reviewed changes

codefromthecrypt approved these changes Mar 5, 2019

View reviewed changes

devinsba mentioned this pull request Mar 6, 2019

WIP Spring Messaging impl openzipkin/brave#572

Closed

devinsba commented Mar 8, 2019

View reviewed changes

marcingrzejszczak added this to the 2.2.0.M1 milestone Mar 29, 2019

spencergibb removed this from the 2.2.0.M1 milestone Jul 3, 2019

devinsba added 2 commits October 2, 2019 18:52

@SqsListener tracing auto-configuration

8644e9e

Fix the formatting of my code, there were 2 classes I needed to revert

6c33937

devinsba requested a review from marcingrzejszczak October 2, 2019 23:53

marcingrzejszczak added this to the 2.2.0.M3 milestone Oct 3, 2019

marcingrzejszczak merged commit dc82c5c into spring-cloud:master Oct 3, 2019

devinsba deleted the sqs-autoconfiguration branch December 2, 2019 21:36

sondemar mentioned this pull request Dec 6, 2022

Micrometer Observations integration for SQS/SNS by default awspring/spring-cloud-aws#566

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SQS Messaging Autoconfig #1218

SQS Messaging Autoconfig #1218

devinsba commented Feb 22, 2019 •

edited

Loading

devinsba commented Feb 26, 2019

codefromthecrypt left a comment

devinsba commented Mar 3, 2019

devinsba Mar 3, 2019

marcingrzejszczak Mar 4, 2019

marcingrzejszczak commented Mar 4, 2019

marcingrzejszczak commented Mar 4, 2019

devinsba commented Mar 4, 2019

codecov-io commented Mar 4, 2019

codecov-io commented Mar 4, 2019 •

edited by codecov bot

Loading

marcingrzejszczak left a comment

devinsba commented Mar 4, 2019

devinsba commented Mar 4, 2019

devinsba commented Mar 5, 2019

codefromthecrypt left a comment

devinsba Mar 8, 2019

devinsba Oct 2, 2019

marcingrzejszczak commented Mar 21, 2019

marcingrzejszczak commented Mar 29, 2019

neoshadybeat commented Sep 3, 2019

		private TraceContext.Extractor<MessageHeaderAccessor> extractor;


		TracingMethodMessageHandlerAdapter(Tracing tracing,

SQS Messaging Autoconfig #1218

SQS Messaging Autoconfig #1218

Conversation

devinsba commented Feb 22, 2019 • edited Loading

devinsba commented Feb 26, 2019

codefromthecrypt left a comment

Choose a reason for hiding this comment

devinsba commented Mar 3, 2019

devinsba Mar 3, 2019

Choose a reason for hiding this comment

marcingrzejszczak Mar 4, 2019

Choose a reason for hiding this comment

marcingrzejszczak commented Mar 4, 2019

marcingrzejszczak commented Mar 4, 2019

devinsba commented Mar 4, 2019

codecov-io commented Mar 4, 2019

Codecov Report

codecov-io commented Mar 4, 2019 • edited by codecov bot Loading

Codecov Report

marcingrzejszczak left a comment

Choose a reason for hiding this comment

devinsba commented Mar 4, 2019

devinsba commented Mar 4, 2019

devinsba commented Mar 5, 2019

codefromthecrypt left a comment

Choose a reason for hiding this comment

devinsba Mar 8, 2019

Choose a reason for hiding this comment

devinsba Oct 2, 2019

Choose a reason for hiding this comment

marcingrzejszczak commented Mar 21, 2019

marcingrzejszczak commented Mar 29, 2019

neoshadybeat commented Sep 3, 2019

devinsba commented Feb 22, 2019 •

edited

Loading

codecov-io commented Mar 4, 2019 •

edited by codecov bot

Loading