Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression when checking declarative methods when argument type is 'Object' #844

Closed
mbogoevici opened this issue Mar 8, 2017 · 0 comments
Closed

Regression when checking declarative methods when argument type is 'Object' #844

mbogoevici opened this issue Mar 8, 2017 · 0 comments
Assignees
@ilayaperumalg
Milestone
1.2.0.RC1

Comments

@mbogoevici
Copy link
Contributor

mbogoevici commented Mar 8, 2017 •
edited by ilayaperumalg

The logic for fixing #664 is treating methods that take Object as argument as declarative, which is a regression. We should revert to previous behaviour (e.g. if Object is an argument, treat it as a message handling method).
@mbogoevici mbogoevici added this to the 1.2.0.RC1 milestone Mar 8, 2017
@mbogoevici mbogoevici mentioned this issue Mar 8, 2017
Closed
@ilayaperumalg ilayaperumalg self-assigned this Mar 9, 2017
ilayaperumalg added a commit to ilayaperumalg/spring-cloud-stream that referenced this issue Mar 9, 2017
@ilayaperumalg
Fix StreamListener method with no explicit declarative method params
341322b 
 - Make sure to check if the method parameters have annotation specified to conclude the method as `declarative` otherwise, it is `handler` method.
 - Add test

Resolves spring-cloud#844
@ilayaperumalg ilayaperumalg mentioned this issue Mar 9, 2017
Closed
@mbogoevici mbogoevici removed the in pr label Mar 13, 2017
sobychacko pushed a commit to sobychacko/spring-cloud-stream that referenced this issue Feb 24, 2022
@olegz
Merge pull request spring-cloud#845 from sobychacko/spring-cloudgh-844
f397f7c 
Kafka streams concurrency with multiple bindings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilayaperumalg ilayaperumalg

Labels
None yet
Projects
None yet
Milestone
1.2.0.RC1
Development

No branches or pull requests
3 participants
@ilayaperumalg @mbogoevici @sabbyanandan