Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing accessors for configuration properties' array members #511

Merged
merged 1 commit into from May 5, 2016

Conversation

mbenson
Copy link
Contributor

@mbenson mbenson commented May 5, 2016

can't configure properly otherwise

@mbogoevici
Copy link
Contributor

@mbogoevici
Copy link
Contributor

Trying to reproduce this: passing the values as a comma separated list will work, but not the explicit array mapping.

spring.cloud.stream.kafka.binder.brokers=localhost:29092,localhost:19092 will work

spring.cloud.stream.kafka.binder.brokers[0]=localhost:29092
spring.cloud.stream.kafka.binder.brokers[1]=localhost:19092 will not (and presumably the YML equivalent)

@mbenson
Copy link
Contributor Author

mbenson commented May 5, 2016

I have signed the CLA, and have several PRs accepted into spring-boot and spring-cloud already.

@mbogoevici
Copy link
Contributor

Cool, thanks. Just wanted to confirm. LGTM, merging.

@mbogoevici mbogoevici merged commit 5b05637 into spring-cloud:master May 5, 2016
@mbogoevici mbogoevici removed the in pr label May 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants