Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POM changes to use version name effectively #650

Closed

Conversation

ilayaperumalg
Copy link
Contributor

No description provided.

@mbogoevici
Copy link
Contributor

mbogoevici commented Sep 15, 2016

Let's hold on to this, until we do the RELEASE. The binders use spring-cloud-stream-parent parent as parent, and this change will cause them to pull in the wrong dependencies (as they set different ${project.version} values. Sharing the parent may not be correct, but we shouldn't make a major change there between RC and RELEASE.

@mbogoevici mbogoevici added this to the 1.2.0.M1 milestone Sep 15, 2016
@ilayaperumalg
Copy link
Contributor Author

Pushed a change that doesn't use parent version inside the sub project.

@mbogoevici
Copy link
Contributor

@mbogoevici mbogoevici modified the milestones: 1.1.1.RELEASE, 1.2.0.M1 Oct 17, 2016
@mbogoevici
Copy link
Contributor

Squashed, merged w/580e268

@mbogoevici mbogoevici closed this Oct 17, 2016
@mbogoevici mbogoevici removed the in pr label Oct 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants