Xd 3244 Initial port of XD MessageBus #8
Conversation
|
I wouldn't block this b/c of Kafka. |
| * | ||
| * @author Marius Bogoevici | ||
| */ | ||
| public class WindowingOffsetManager implements OffsetManager, InitializingBean, DisposableBean { |
There was a problem hiding this comment.
This class is shared with the Kafka Source so we should ideally move it to Spring Integration Kafka eventually. Beyond the scope of this PR, but needs a reminder.
|
There's something funky with this PR and STS; looks like there's a transitive dep on xd-codec someplace - I am seeing unused imports ( When I fix imports (in STS) it pulls in 2 imports for each). In the CP, spring-xd-codec is there. |
| protected static class CodecConfiguration { | ||
| @Autowired | ||
| ApplicationContext applicationContext; | ||
|
|
||
| @Bean | ||
| @ConditionalOnMissingBean(name = "codec") | ||
| public MultiTypeCodec<?> codec() { | ||
| Map<String, KryoRegistrar> kryoRegistrarMap = this.applicationContext.getBeansOfType(KryoRegistrar | ||
| public MultiTypeCodec codec() { |
There was a problem hiding this comment.
Yeah, its from the test dep on tuple. I will exclude
ultrafox:/s2build/spring-cloud-streams/spring-cloud-streams-bindings[XD-3244]/s2build/spring-cloud-streams/spring-cloud-streams-bindings[XD-3244]
$ mvn dependency:tree | grep spring-xd
[INFO] +- org.springframework.xd:spring-xd-tuple:jar:1.2.1.BUILD-SNAPSHOT:test
[INFO] | +- org.springframework.xd:spring-xd-codec:jar:1.2.1.BUILD-SNAPSHOT:test
[INFO] | | - org.springframework.xd:spring-xd-spi-common:jar:1.2.1.BUILD-SNAPSHOT:test
[INFO] +- org.springframework.xd:spring-xd-tuple:jar:1.2.1.BUILD-SNAPSHOT:test
[INFO] | +- org.springframework.xd:spring-xd-codec:jar:1.2.1.BUILD-SNAPSHOT:test
[INFO] | | - org.springframework.xd:spring-xd-spi-common:jar:1.2.1.BUILD-SNAPSHOT:test
[INFO] +- org.springframework.xd:spring-xd-tuple:jar:1.2.1.BUILD-SNAPSHOT:test
[INFO] | +- org.springframework.xd:spring-xd-codec:jar:1.2.1.BUILD-SNAPSHOT:test
[INFO] | | - org.springframework.xd:spring-xd-spi-common:jar:1.2.1.BUILD-SNAPSHOT:test
ultrafox:
There was a problem hiding this comment.
should be better now
|
@dturanski re #9 you can just add this commit to your PR if you like... |
|
Maybe it's not such a great idea to use the same packages. It can cause all kinds of problems if people have cr*p on their classpath. |
|
Here's an updated commit for #9 |
|
rebased my #9 commit |
|
Added commits for changing to JDK7 build and move transport specific packages in binding-test to specific transport test projects. Squashed and merged as 5377eaf |
This brings over XD MessageBus code basically as-is:
The test code had to be rearranged to bring in relevant MB test packages from DIRT and some of the Test harness needed refactoring to sort out dependencies. Currently everything is under spring-cloud-streams-bindings. There is a common test project spring-cloud-streams-binding-test. This should take another iteration in a future PR to separate out transport specific things as much as possible. spring-xd-dirt supported testing all transports and had some common base classes, etc. these were dealt out to the binding-* components to get to this point.