Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PersonRepository#findByTeammatesName and use it #36

Merged
merged 4 commits into from
Aug 6, 2020

Conversation

talkingscott
Copy link
Contributor

The guide already refers to findByTeammatesName and its use in main(), but the code does not match the text. This PR adds that method to the repository class and uses it in the CommandLineRunner. I additionally call System.exit(0) from main() as otherwise active threads leave the application running after the return.

@Buzzardo
Copy link
Contributor

I asked Greg Turnquist to review this one, too. We don't usually add an exit call.

@talkingscott
Copy link
Contributor Author

Messaging with Redis calls exit, which is where I got the idea. I see that Messaging with RabbitMQ calls close: SpringApplication.run(MessagingRabbitmqApplication.class, args).close();. That looks more idiomatic.

@Buzzardo Buzzardo merged commit e2d79a3 into spring-guides:master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants