Switch to dockerfile-maven-plugin v1.3.4 #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated gradle to use Dockerfile from project base
…/gs-spring-boot-docker into issue_5_dockerfile_maven_plugin
dsyer
requested changes
Jul 23, 2017
| @@ -1,6 +1,5 @@ | |||
| FROM frolvlad/alpine-oraclejdk8:slim | |||
| VOLUME /tmp | |||
| ADD target/gs-spring-boot-docker-0.1.0.jar app.jar | |||
| RUN sh -c 'touch /app.jar' | |||
There was a problem hiding this comment.
If we are taking this out we should also take out the explanation below.
|
Thanks. Cherry picked (to avoid the need for some of the git wrangling you did). See 7f1da46. |
This was referenced Jul 24, 2017
Closed
|
Thanks for cherry picking some of the commits. I have opened #31 to address one last change in the README from this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated gradle to use Dockerfile from project base
Fixes #27 and #28