-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to dockerfile-maven-plugin v1.3.4 #29
Switch to dockerfile-maven-plugin v1.3.4 #29
Conversation
Updated gradle to use Dockerfile from project base
…/gs-spring-boot-docker into issue_5_dockerfile_maven_plugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good mostly.
@@ -1,6 +1,5 @@ | |||
FROM frolvlad/alpine-oraclejdk8:slim | |||
VOLUME /tmp | |||
ADD target/gs-spring-boot-docker-0.1.0.jar app.jar | |||
RUN sh -c 'touch /app.jar' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are taking this out we should also take out the explanation below.
Thanks. Cherry picked (to avoid the need for some of the git wrangling you did). See 7f1da46. |
Thanks for cherry picking some of the commits. I have opened #31 to address one last change in the README from this pull request. |
Updated gradle to use Dockerfile from project base
Fixes #27 and #28