Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot set contentType on @SendTo replies #1219

Closed
garyrussell opened this issue Jul 6, 2020 · 0 comments · Fixed by #1221
Closed

Cannot set contentType on @SendTo replies #1219

garyrussell opened this issue Jul 6, 2020 · 0 comments · Fixed by #1221

Comments

@garyrussell
Copy link
Contributor

garyrussell commented Jul 6, 2020

See https://stackoverflow.com/questions/62587234/content-type-different-in-rabbitlistener-spring-amqp-using-contenttypedelegating/62596320#comment110986120_62596320

The problem is when using a ContentTypeDelegatingMessageConverter - it is called before the header is mapped.

@garyrussell garyrussell added this to the 2.3.M2 milestone Jul 6, 2020
@garyrussell garyrussell self-assigned this Jul 6, 2020
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Jul 6, 2020
Resolves spring-projects#1219

The headers were mapped after message conversion.
This prevented using a `ContentTypeDelegatingMessageConverter` because
the content type was not set.

**cherry-pick to 2.2.x, 2.1.x, 1.7.x**
garyrussell added a commit to garyrussell/spring-amqp that referenced this issue Jul 6, 2020
Resolves spring-projects#1219

The headers were mapped after message conversion.
This prevented using a `ContentTypeDelegatingMessageConverter` because
the content type was not set.

Add a header to control whether the user or converter gets to set the
content type property in the final message.

**cherry-pick to 2.2.x, 2.1.x, 1.7.x**
artembilan pushed a commit that referenced this issue Jul 7, 2020
Resolves #1219

The headers were mapped after message conversion.
This prevented using a `ContentTypeDelegatingMessageConverter` because
the content type was not set.

Add a header to control whether the user or converter gets to set the
content type property in the final message.

**cherry-pick to 2.2.x, 2.1.x, 1.7.x**
artembilan pushed a commit that referenced this issue Jul 7, 2020
Resolves #1219

The headers were mapped after message conversion.
This prevented using a `ContentTypeDelegatingMessageConverter` because
the content type was not set.

Add a header to control whether the user or converter gets to set the
content type property in the final message.

**cherry-pick to 2.2.x, 2.1.x, 1.7.x**
artembilan pushed a commit that referenced this issue Jul 7, 2020
Resolves #1219

The headers were mapped after message conversion.
This prevented using a `ContentTypeDelegatingMessageConverter` because
the content type was not set.

Add a header to control whether the user or converter gets to set the
content type property in the final message.

**cherry-pick to 2.2.x, 2.1.x, 1.7.x**

# Conflicts:
#	spring-amqp/src/main/java/org/springframework/amqp/support/AmqpHeaders.java
#	spring-amqp/src/main/java/org/springframework/amqp/support/converter/MessagingMessageConverter.java
#	src/reference/asciidoc/amqp.adoc
artembilan pushed a commit that referenced this issue Jul 7, 2020
Resolves #1219

The headers were mapped after message conversion.
This prevented using a `ContentTypeDelegatingMessageConverter` because
the content type was not set.

Add a header to control whether the user or converter gets to set the
content type property in the final message.

**cherry-pick to 2.2.x, 2.1.x, 1.7.x**

# Conflicts:
#	spring-amqp/src/main/java/org/springframework/amqp/support/AmqpHeaders.java
#	spring-amqp/src/main/java/org/springframework/amqp/support/converter/MessagingMessageConverter.java
#	src/reference/asciidoc/amqp.adoc

# Conflicts:
#	src/reference/asciidoc/amqp.adoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment