AMQP-764: Move Setting stopped to destroy() [Backport] #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA: https://jira.spring.io/browse/AMQP-764 Fixes spring-projects#651 Previously, `stopped` was set in `stop()` after the context was closed. This was done to prevent inadvertent re-opening of the connection which would prevent the application from terminating. This was too early since other beans destroyed before the factory might need to send messages. Remove `Smartlifecycle` and move setting `stopped` to `destroy()`, but still only after the context is closed; since `destroy()` can be called by users to reset the connection (although `resetConnection()` is now the preferred way to do that. Conflicts: spring-rabbit/src/main/java/org/springframework/amqp/rabbit/connection/CachingConnectionFactory.java Resolved.
garyrussell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.spring.io/browse/AMQP-764
Fixes #651
Previously,
stoppedwas set instop()after the context was closed.This was done to prevent inadvertent re-opening of the connection which
would prevent the application from terminating.
This was too early since other beans destroyed before the factory might
need to send messages.
Remove
Smartlifecycleand move settingstoppedtodestroy(), butstill only after the context is closed; since
destroy()can be calledby users to reset the connection (although
resetConnection()is now thepreferred way to do that.
cherry-pick to 1.6.x