Add support to build/run on Java 11 #640
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required to be able to test against Java 11. In Java 11, JAXB is removed from the JDK (See http://openjdk.java.net/jeps/320). This commit fixes errors of type: ``` StaxEventItemWriterTests.java:22: error: package javax.xml.bind.annotation does not exist: import javax.xml.bind.annotation.XmlRootElement; ``` Two important points (from JEP 320) to note about this commit: * `Another risk of removing the Java EE modules is that applications which already migrated from JDK 6, 7, or 8, to JDK 9, will not start if they use the command line flag --add-modules java.se.ee, --add-modules java.xml.bind, etc.` This commit removes the need to add the flag `--add-modules java.xml.bind`. This removal does not impact building on Java 9 since JAXB is in the class path now. * `The Reference Implementations (RIs) of JAX-WS and JAXB are a good starting point because they are complete replacements for the java.xml.ws and java.xml.bind modules in JDK 9. The RIs are available as Maven artifacts: (note that they must be deployed on the class path)` This commit adds JAXB to the test class path where needed. Issue: BATCH-2757
fmbenhassine
force-pushed
the
BATCH-2757
branch
from
143b9b4
to
a117dcb
Compare
|
LGTM. Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves BATC-2757.
It fixes compilation/test issues on Java 11 due to the removal of JAXB from the JDK (See JEP-320). More details in the commit message.
The
asciidoctask fails on Java 11 due to a transitive dependency of jruby (jruby-openssl) which is not compatible yet with Java 11 (See https://github.com/jruby/jruby-openssl#compatibility).So this PR can be tested using the following command:
./gradlew clean build -x asciidoc. The build should succeed with Open JDK 11 ea 28 (from SDKMAN11.ea.28-open).Note: This PR should be merged after #639.