Handle null items as advertized in the Javadoc

See gh-22344
spring-projects · Jul 16, 2020 · 267283e · 267283e
1 parent f3e2e6c
commit 267283e
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 2 deletions.
diff --git a/...gure/src/main/java/org/springframework/boot/autoconfigure/condition/ConditionMessage.java b/...gure/src/main/java/org/springframework/boot/autoconfigure/condition/ConditionMessage.java
@@ -381,7 +381,8 @@ public ConditionMessage items(Style style, Collection<?> items) {
 			Assert.notNull(style, "Style must not be null");
 			StringBuilder message = new StringBuilder(this.reason);
 			items = style.applyTo(items);
-			if ((this.condition == null || items.size() <= 1) && StringUtils.hasLength(this.singular)) {
+			if ((this.condition == null || items == null || items.size() <= 1)
+					&& StringUtils.hasLength(this.singular)) {
 				message.append(" ").append(this.singular);
 			}
 			else if (StringUtils.hasLength(this.plural)) {
@@ -420,6 +421,9 @@ protected String applyToItem(Object item) {
 		};
 
 		public Collection<?> applyTo(Collection<?> items) {
+			if (items == null) {
+				return null;
+			}
 			List<Object> result = new ArrayList<>(items.size());
 			for (Object item : items) {
 				result.add(applyToItem(item));

diff --git a/...src/test/java/org/springframework/boot/autoconfigure/condition/ConditionMessageTests.java b/...src/test/java/org/springframework/boot/autoconfigure/condition/ConditionMessageTests.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2019 the original author or authors.
+ * Copyright 2012-2020 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -17,6 +17,7 @@
 package org.springframework.boot.autoconfigure.condition;
 
 import java.util.ArrayList;
+import java.util.Collection;
 import java.util.List;
 
 import org.junit.jupiter.api.Test;
@@ -188,4 +189,19 @@ void availableShouldConstructMessage() {
 		assertThat(message.toString()).isEqualTo("@Test JMX is available");
 	}
 
+	@Test
+	void itemsTolerateNullInput() {
+		Collection<?> items = null;
+		ConditionMessage message = ConditionMessage.forCondition(Test.class).didNotFind("item").items(items);
+		assertThat(message.toString()).isEqualTo("@Test did not find item");
+	}
+
+	@Test
+	void quotedItemsTolerateNullInput() {
+		Collection<?> items = null;
+		ConditionMessage message = ConditionMessage.forCondition(Test.class).didNotFind("item").items(Style.QUOTE,
+				items);
+		assertThat(message.toString()).isEqualTo("@Test did not find item");
+	}
+
 }