Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConditionMessage#items throws an NPE with a null list of items although the Javadoc states it is tolerated #22344

Closed
wants to merge 2 commits into from
Closed

ConditionMessage#items throws an NPE with a null list of items although the Javadoc states it is tolerated #22344

wants to merge 2 commits into from

Conversation

dreis2211
Copy link
Contributor

@dreis2211 dreis2211 commented Jul 15, 2020 •
edited

Hi,

as noted in #22330 the several items methods in ConditionMessage state that the passed items might be null.

* @param items the source of the items (may be {@code null})

Yet, currently they would thrown a NPE if null would be passed. This PR fixes that.

Cheers,
Christoph

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 15, 2020
@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 15, 2020
@philwebb philwebb added this to the 2.4.x milestone Jul 15, 2020
@snicoll snicoll self-assigned this Jul 16, 2020
@snicoll snicoll added type: bug A general bug and removed type: enhancement A general enhancement labels Jul 16, 2020
@snicoll snicoll modified the milestones: 2.4.x, 2.3.2 Jul 16, 2020
@snicoll snicoll changed the title Tolerate null items in ConditionMessage ConditionMessage#items throws an NPE with a null list of items although the Javadoc states it is tolerated Jul 16, 2020
snicoll pushed a commit that referenced this pull request Jul 16, 2020
@dreis2211 @snicoll
Handle null items as advertized in the Javadoc
267283e 
See gh-22344
@snicoll snicoll mentioned this pull request Jul 16, 2020
Closed
@snicoll snicoll closed this in 7028231 Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@snicoll snicoll

Labels
type: bug A general bug
Projects
None yet
Milestone
2.3.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dreis2211 @snicoll @philwebb @spring-projects-issues