Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to JUnit Jupiter 5.5.0-RC2 #17266

Closed
snicoll opened this issue Jun 19, 2019 · 3 comments
Closed

Upgrade to JUnit Jupiter 5.5.0-RC2 #17266

snicoll opened this issue Jun 19, 2019 · 3 comments
Assignees
Labels
type: dependency-upgrade A dependency upgrade
Milestone

Comments

@snicoll
Copy link
Member

snicoll commented Jun 19, 2019

This also gives us an opportunity to simplify the build setup required to exclude the vintage engine now that junit-team/junit5#1872 has been fixed.

@snicoll
Copy link
Member Author

snicoll commented Jun 19, 2019

The upgrade has broken the build:

org.junit.platform.commons.PreconditionViolationException: Failed to register extension via @RegisterExtension field [private org.springframework.boot.cli.CliTester org.springframework.boot.cli.RunCommandIntegrationTests.cli]: field must not be private.
	at org.junit.platform.commons.util.Preconditions.condition(Preconditions.java:296)
	at org.junit.jupiter.engine.descriptor.ExtensionUtils.lambda$registerExtensionsFromFields$3(ExtensionUtils.java:103)
	at java.util.ArrayList.forEach(ArrayList.java:1257)
	at org.junit.jupiter.engine.descriptor.ExtensionUtils.registerExtensionsFromFields(ExtensionUtils.java:102)
	at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.instantiateAndPostProcessTestInstance(ClassBasedTestDescriptor.java:262)
	at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$testInstancesProvider$2(ClassBasedTestDescriptor.java:247)
	at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$testInstancesProvider$3(ClassBasedTestDescriptor.java:251)
	at java.util.Optional.orElseGet(Optional.java:267)
	at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$testInstancesProvider$4(ClassBasedTestDescriptor.java:250)

@snicoll snicoll reopened this Jun 19, 2019
@wilkinsona
Copy link
Member

CliTester needs to be registered as an extension as it's a before each and after each callback.

@wilkinsona wilkinsona reopened this Jun 19, 2019
@snicoll snicoll changed the title Upgrade to JUnit Jupiter 5.5.0-RC1 Upgrade to JUnit Jupiter 5.5.0-RC2 Jun 21, 2019
@snicoll
Copy link
Member Author

snicoll commented Jun 21, 2019

RC2 is out in the meantime so let's reuse this issue to update to it

snicoll added a commit that referenced this issue Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: dependency-upgrade A dependency upgrade
Projects
None yet
Development

No branches or pull requests

2 participants