Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Undertow's server and socket options to be configured via the environment #6715

Closed
wilkinsona opened this issue Aug 22, 2016 · 4 comments
Assignees
Labels
status: superseded An issue that has been superseded by another type: enhancement A general enhancement

Comments

@wilkinsona
Copy link
Member

Something like:

server.undertow.options.socket.whatever: foo
server.undertow.options.server.whatever: bar

whatever is then coerced into one of the constants on UndertowOptions, ideally with relaxed binding. A concrete example:

server.undertow.options.server.enable-http2: true

See #3350 which this issue probably supersedes.

@wilkinsona wilkinsona added the type: enhancement A general enhancement label Aug 22, 2016
@snicoll
Copy link
Member

snicoll commented Aug 22, 2016

Enum has already some kind of relaxed bindings and you'll need to make a Map<UndertowOptions, Object> to make that work. I believe the jackson support has something of the kind for includes.

@wilkinsona
Copy link
Member Author

If only UndertowOptions were an Enum

@cbelleza

This comment has been minimized.

@wilkinsona wilkinsona added this to the General Backlog milestone Jan 15, 2019
htztomic added a commit to htztomic/spring-boot that referenced this issue Jun 28, 2019
htztomic added a commit to htztomic/spring-boot that referenced this issue Jun 28, 2019
htztomic added a commit to htztomic/spring-boot that referenced this issue Jul 1, 2019
@mbhave
Copy link
Contributor

mbhave commented Jul 1, 2019

Closing in favor of PR #17356.

@mbhave mbhave closed this as completed Jul 1, 2019
@mbhave mbhave removed this from the General Backlog milestone Jul 1, 2019
@mbhave mbhave added the status: superseded An issue that has been superseded by another label Jul 1, 2019
htztomic added a commit to htztomic/spring-boot that referenced this issue Jul 3, 2019
htztomic added a commit to htztomic/spring-boot that referenced this issue Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded An issue that has been superseded by another type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

6 participants