-
Notifications
You must be signed in to change notification settings - Fork 40.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-configure jOOQ with TransactionListenerProvider #13331
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. See comment for more details.
public DslContextConfiguration(JooqProperties properties, | ||
ConnectionProvider connectionProvider, DataSource dataSource, | ||
ObjectProvider<TransactionProvider> transactionProvider, | ||
ObjectProvider<RecordMapperProvider> recordMapperProvider, | ||
ObjectProvider<RecordUnmapperProvider> recordUnmapperProvider, | ||
ObjectProvider<Settings> settings, | ||
ObjectProvider<RecordListenerProvider[]> recordListenerProviders, | ||
ExecuteListenerProvider[] executeListenerProviders, | ||
ObjectProvider<VisitListenerProvider[]> visitListenerProviders) { | ||
ObjectProvider<ExecuteListenerProvider[]> executeListenerProviders, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That change in ExecuteListenerProvider
is unrelated to the purpose of this PR. Please revert it so that this change is properly focused.
@snicoll done. Do you still need |
Thank you @nosan
It's a very small change, I'll polish behind if necessary |
There is |
* pr/13331: Auto-configure jOOQ with TransactionListenerProvider
see gh-13329