Auto-configure jOOQ to use an ExecutorProvider bean if available #14471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improvement allow to define a custom Executor for Jooq. To provide it, you have to wrap it under a org.jooq.ExecutorProvider. This is useful in multiple case, especially for testing in my case when I want to run my @Sql() test inside a transaction with `fetchAsync` which wasn't compatible. Thanks to this, we can in our test use the SyncTaskExecutor to use the `main` thread for all our tests.
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
changed the title
|
Thanks for the PR. I'm not totally sold on davinkevin@bf4e36c, I wonder if using |
wilkinsona
pushed a commit
that referenced
this pull request
Sep 17, 2018
wilkinsona
added a commit
that referenced
this pull request
Sep 17, 2018
* gh-14471: Polish "Use ExecutorProvider bean if available when auto-configuring jOOQ" Use ExecutorProvider bean if available when auto-configuring jOOQ
|
@davinkevin Thank you very much for your contribution. The proposed changes have now been merged into master. I also applied a small polishing commit, the main part of which was a small update to the documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improvement allow to define a custom Executor for Jooq. To provide it, you have to wrap it under a
org.jooq.ExecutorProvider. This is useful in multiple case, especially for testing in my case when I want to run my@Sql()test inside a transaction withfetchAsyncwhich wasn't compatible. Thanks to this, we can in our test use theSyncTaskExecutorto use themainthread for all our tests.BTW, I've made some code modification in another commit (not in this PR) to simplify (from my point of view) the configuration system (using the
ObjectProviderinstead of relying on null). Do you think I can make a PR of this (davinkevin@bf4e36c) ?