Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore isPositive check for maxHttpHeaderSize #14986

Closed
wants to merge 1 commit into from
Closed

Restore isPositive check for maxHttpHeaderSize #14986

wants to merge 1 commit into from

Commits on Oct 28, 2018

  1. Restore isPositive check for maxHttpHeaderSize. 

    - 1.5 and 2.0 releases used Tomcat's default max header size when the
  configured server.max-http-header-size was 0, but that has regressed
  in 2.1.0.RC1 and now the max is set to 0 when configured as 0
  - Added unit tests to verify -1 and 0 use Tomcat's default 8K limit
- Configuring a max of 0 prevents all HTTP processing, since no headers
  can be set, which makes no sense
    Bryan Turner committed Oct 28, 2018
    Configuration menu
    Copy the full SHA
    a022670 View commit details
    Browse the repository at this point in the history