Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache MimeTypes to improve performance #16507

Closed
wants to merge 2 commits into from

Conversation

aftersss
Copy link

Consider that MimeTypeUtils.parseMimeType's performance is not very good, MimeTypeUtils::parseMimeType should be called earlier to avoid the cost. See also: spring-projects/spring-framework#22598

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 10, 2019
snicoll pushed a commit that referenced this pull request Apr 19, 2019
snicoll added a commit that referenced this pull request Apr 19, 2019
* pr/16507:
  Polish "Cache MimeTypes to improve performance"
  Cache MimeTypes to improve performance
@snicoll snicoll closed this in 2448efc Apr 19, 2019
@snicoll snicoll changed the title Call MimeTypeUtils::parseMimeType earlier to improve performance Cache MimeTypes to improve performance Apr 19, 2019
@snicoll snicoll self-assigned this Apr 19, 2019
@snicoll snicoll added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 19, 2019
@snicoll snicoll added this to the 2.1.5 milestone Apr 19, 2019
@snicoll
Copy link
Member

snicoll commented Apr 19, 2019

@aftersss thank you for making your first contribution to Spring Boot. This is merged in 2.1.x and master with a polish commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants