Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow AbstractDependsOnBeanFactoryPostProcessor to identify depended on beans by type #17020

Closed
wants to merge 1 commit into from
Closed

Allow AbstractDependsOnBeanFactoryPostProcessor to identify depended on beans by type #17020

wants to merge 1 commit into from

Conversation

nosan
Copy link
Contributor

@nosan nosan commented May 30, 2019

Add to AbstractDependsOnBeanFactoryPostProcessor new constructors to specify that bean and factory bean depends on particular types.

Prior to this commit, the AbstractDependsOnBeanFactoryPostProcessor
can be used only with bean names.

It could be useful in case of gh-16627

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 30, 2019
@nosan nosan force-pushed the enhancement-1 branch 2 times, most recently from 1190e6c to f475ab5 Compare June 4, 2019 12:14
@nosan nosan force-pushed the enhancement-1 branch 3 times, most recently from 4acac6f to 408e910 Compare June 10, 2019 13:17
@ielatif
Copy link
Contributor

ielatif commented Jun 20, 2019

It could be useful in case of gh-16627

👍

@nosan nosan changed the title Add to AbstractDependsOnBeanFactoryPostProcessor new constructors Add to AbstractDependsOnBeanFactoryPostProcessor new constructors to specify that bean can be dependent on particular bean types. Jun 21, 2019
@nosan
Add to AbstractDependsOnBeanFactoryPostProcessor new constructors to …
8ecb3ea 
…specify

that bean can be dependent on particular bean types.

Prior to this commit, the `AbstractDependsOnBeanFactoryPostProcessor`
can be used only with bean names.
@wilkinsona wilkinsona added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 10, 2019
@wilkinsona wilkinsona added this to the 2.1.x milestone Jul 10, 2019
@wilkinsona wilkinsona self-assigned this Jul 10, 2019
@wilkinsona wilkinsona changed the title Add to AbstractDependsOnBeanFactoryPostProcessor new constructors to specify that bean can be dependent on particular bean types. Allow AbstractDependsOnBeanFactoryPostProcessor to identify depended on beans by type Jul 10, 2019
@wilkinsona wilkinsona mentioned this pull request Jul 10, 2019
Closed
wilkinsona pushed a commit that referenced this pull request Jul 10, 2019
@nosan @wilkinsona
Allow depended on beans to be identified by type
9923ffe 
Prior to this commit, `AbstractDependsOnBeanFactoryPostProcessor`
could only identify depended on beans by name.

See gh-17020
wilkinsona added a commit that referenced this pull request Jul 10, 2019
@wilkinsona
Polish "Allow depended on beans to be identified by type"
80650f4 
See gh-17020
@wilkinsona
Copy link
Member

Thanks very much, @nosan. If you're interested, I polished things a little bit in 80650f4 to avoid the logic branches for dealing with String[] vs Class[].

@wilkinsona wilkinsona modified the milestones: 2.1.x, 2.1.7 Jul 10, 2019
@nosan
Copy link
Contributor Author

nosan commented Jul 10, 2019

Thank you very much @wilkinsona

@nosan nosan deleted the enhancement-1 branch July 10, 2019 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wilkinsona wilkinsona

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.1.7
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nosan @ielatif @wilkinsona @spring-projects-issues