Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register Printer<T> and Parser<T> beans as converters #17064

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@nosan
Copy link
Contributor

commented Jun 5, 2019

Registers Printer<T> and Parser<T> as converters if they have been exposed as beans.

see gh-16171

@philwebb

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

I raise spring-projects/spring-framework#23110 to see if we can't improve Spring Framework first. It's a bit nasty that we need new PrintConverter and ParseConverter public classes.

@philwebb philwebb self-assigned this Jun 11, 2019

philwebb added a commit that referenced this pull request Jun 13, 2019

Add Printer and Parser beans to conversion service
Update `WebMvcAutoConfiguration` and `WebFluxAutoConfiguration` so that
`Printer<T>` and `Parser<T>` beans are automatically registered with
the conversion service.

Prior to this commit only `GenericConverter`, `Converter` and
`Formatter` beans were automatically registered.

See gh-17064

philwebb added a commit that referenced this pull request Jun 13, 2019

Polish "Add Printer and Parser beans to conversion service"
Extract common registration code and make use of the Spring Framework
registration methods.

See gh-17064

@philwebb philwebb closed this in 0f642df Jun 13, 2019

@philwebb

This comment has been minimized.

Copy link
Member

commented Jun 13, 2019

Thanks for the PR @nosan! This is now in master. With the spring-projects/spring-framework#23110 change I've been able to simplify it as we no longer need our own PrinterConverter and ParserConverter classes.

@philwebb philwebb modified the milestones: 2.2.x, 2.2.0.M4 Jun 13, 2019

@nosan

This comment has been minimized.

Copy link
Contributor Author

commented Jun 13, 2019

Thank you very much @philwebb

@nosan nosan deleted the nosan:gh-16171 branch Jun 13, 2019

@wilkinsona wilkinsona changed the title Registers Printer<T> and Parser<T> as converters Register Printer<T> and Parser<T> beans as converters Jun 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.