Trimming the whitespace for the OAuth2 provider property #17497
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
nosan
changed the title
mbhave
reviewed
Jul 12, 2019
| @@ -75,7 +75,8 @@ private static ClientRegistration getClientRegistration(String registrationId, | |||
|
|
|||
| private static Builder getBuilderFromIssuerIfPossible(String registrationId, String configuredProviderId, | |||
| Map<String, Provider> providers) { | |||
| String providerId = (configuredProviderId != null) ? configuredProviderId : registrationId; | |||
| String providerId = StringUtils | |||
| .trimWhitespace((configuredProviderId != null) ? configuredProviderId : registrationId); | |||
There was a problem hiding this comment.
I think this logic can be moved a level up to avoid duplication of the trimming logic?
There was a problem hiding this comment.
I suppose it doesn't hurt to trim it but I don't think it's possible to have whitespace at the end of the registrationId since it's a key in the map.
There was a problem hiding this comment.
I don't think it's possible to have whitespace at the end of the registrationId since it's a key in the map
I've just realized this and removed my last comment.
mbhave
added
type: bug
philwebb
pushed a commit
that referenced
this pull request
Jul 24, 2019
Update `OAuth2ClientPropertiesRegistrationAdapter` to trim whitespace of the "provider" property. See gh-17497
|
Thanks, @philwebb |
snicoll
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see gh-17487