Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand documentation on remote devtools #17780

Closed
wants to merge 1 commit into from
Closed

Expand documentation on remote devtools #17780

wants to merge 1 commit into from

Conversation

forketyfork
Copy link
Contributor

While setting up devtools in remote mode, I've found some peculiarities not described in the docs, related to file system watcher and security configuration. The related exceptions in the logs are explainable after digging through the devtools code, but very obscure otherwise. So I believe this should be part of the documentation.

@pivotal-issuemaster
Copy link

@forketyfork Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@forketyfork Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 4, 2019
@philwebb philwebb added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 5, 2019
@philwebb philwebb added this to the 2.1.x milestone Aug 5, 2019
@mbhave mbhave added the for: team-attention An issue we'd like other members of the team to review label Aug 12, 2019
@wilkinsona wilkinsona assigned wilkinsona and mbhave and unassigned wilkinsona Aug 14, 2019
@mbhave mbhave changed the title Added sections about file system watcher configuration and security c… Expand documentation on remote devtools Aug 15, 2019
@mbhave mbhave removed the for: team-attention An issue we'd like other members of the team to review label Aug 15, 2019
mbhave pushed a commit that referenced this pull request Aug 15, 2019
mbhave added a commit that referenced this pull request Aug 15, 2019
@mbhave mbhave closed this in c4dd386 Aug 15, 2019
@mbhave
Copy link
Contributor

mbhave commented Aug 15, 2019

Thanks for the PR @forketyfork. This has now been merged into master along with this polish commit. For master, I've removed the note about the additional security config since it is not needed following this issue.

@mbhave mbhave modified the milestones: 2.1.x, 2.1.8 Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants