Simplify code #18175
Simplify code #18175
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
There was a problem hiding this comment.
Thanks for the PR! I don't think that Math.max is an improvement. I'll give a few more days for other team members to chime in and share their thoughts.
I've seen you closed #18166. There is no need to create another PR when changes are requested, just push additional commits on your branch and this will update the PR.
| @@ -167,7 +167,7 @@ protected JettyResourceFactory getResourceFactory() { | |||
| } | |||
|
|
|||
| protected Server createJettyServer(JettyHttpHandlerAdapter servlet) { | |||
| int port = (getPort() >= 0) ? getPort() : 0; | |||
| int port = Math.max(getPort(), 0); | |||
There was a problem hiding this comment.
I think the intention of the current code is clearer. We want to set the port to 0 if it's null or negative. My brain has to parse the .max so I am not keen to merge this change.
There was a problem hiding this comment.
I prefer the proposed change. I find it no harder to read than what we currently have, with the advantage that getPort() is only called once so it doesn't make me pause and wonder if the value could change between calls.
There was a problem hiding this comment.
I'm happy with the change as well
There was a problem hiding this comment.
Thanks both. I am not feeling strongly against it so I'll go ahead and process with the merge.
snicoll
added
for: team-attention
|
@gaohanghang thank you for making your first contribution to Spring Boot. |
👌, Thanks |
No description provided.