Skip to content

Simplify code #18166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Simplify code #18166

wants to merge 4 commits into from

Conversation

gaohanghang
Copy link
Contributor

  1. Use Math.max() and lambda expression simplify some code.
  2. Use Long.parseLong() replace Long.valueOf()

@pivotal-issuemaster
Copy link

@gaohanghang Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 6, 2019
@pivotal-issuemaster
Copy link

@gaohanghang Thank you for signing the Contributor License Agreement!

@snicoll
Copy link
Member

snicoll commented Sep 6, 2019 •
edited
Loading

@gaohanghang Thank you for the PR. In order to reduce the noise of notification, please run the build locally and fix violations before submitting rather than relying on our CI to detect them.

@gaohanghang
Copy link
Contributor Author

@gaohanghang Thank you for the PR. In order to reduce the noise of notification, please run the build locally and fix violations before submitting rather than relying on our CI to detect them.

Sorry, thank you for your suggestion.

@gaohanghang gaohanghang closed this Sep 6, 2019
philwebb
philwebb reviewed Sep 6, 2019
View reviewed changes
spring-boot-project/spring-boot/src/main/java/org/springframework/boot/logging/DeferredLog.java
@@ -232,7 +232,6 @@ private static void logTo(Log log, LogLevel level, Object message, Throwable thr
return;
case FATAL:
log.fatal(message, throwable);
return;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to leave this in for consistency with the other statements. The other changes look like nice improvements. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌Thank you for code review.

@snicoll snicoll removed the status: waiting-for-triage An issue we've not yet triaged label Sep 8, 2019
@gaohanghang gaohanghang mentioned this pull request Sep 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philwebb philwebb philwebb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gaohanghang @pivotal-issuemaster @snicoll @philwebb @spring-projects-issues