Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PoolingDataSourceBean getParentLogger throws StackOverflowError #19637

Closed
wants to merge 1 commit into from
Closed

PoolingDataSourceBean getParentLogger throws StackOverflowError #19637

wants to merge 1 commit into from

Conversation

nosan
Copy link
Contributor

@nosan nosan commented Jan 11, 2020

see gh-19636

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 11, 2020
@wilkinsona wilkinsona mentioned this pull request Jan 12, 2020
Closed
@wilkinsona wilkinsona changed the title Fix StackOverflowError in PoolingDataSourceBean PoolingDataSourceBean getParentLogger always returns global logger due to StackOverflowError Jan 12, 2020
@wilkinsona wilkinsona added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 12, 2020
@wilkinsona wilkinsona added this to the 2.1.x milestone Jan 12, 2020
@nosan
Copy link
Contributor Author

nosan commented Jan 12, 2020

@wilkinsona
Actually it does not return a global logger 😄 , it always throws StackOverflowError

@wilkinsona
Copy link
Member

Thanks, @nosan. Because it's catching Exception rather than Throwable.

@wilkinsona wilkinsona changed the title PoolingDataSourceBean getParentLogger always returns global logger due to StackOverflowError PoolingDataSourceBean getParentLogger throws StackOverflowError Jan 12, 2020
@snicoll snicoll self-assigned this Jan 13, 2020
snicoll pushed a commit that referenced this pull request Jan 13, 2020
@nosan @snicoll
Fix retrieval of parent logger in PoolingDataSourceBean
b7e6989 
See gh-19637
This was referenced Jan 13, 2020
Closed
Closed
@snicoll snicoll modified the milestones: 2.1.x, 2.1.12 Jan 13, 2020
@snicoll snicoll closed this in e87ed08 Jan 13, 2020
@snicoll
Copy link
Member

snicoll commented Jan 13, 2020

Thanks a lot @nosan

@nosan nosan deleted the gh-19636 branch January 28, 2020 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@snicoll snicoll

Labels
type: bug A general bug
Projects
None yet
Milestone
2.1.12
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nosan @wilkinsona @snicoll @spring-projects-issues