Upgrade group("com.squareup.okhttp3") to 4.4.1 and start using bom. #20592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Upgrade OkHttp to 4.4.1 According to https://square.github.io/okhttp/upgrading_to_okhttp_4/, 4.x has perfect binary compatibility for 3.x > Binary compatibility is the ability to compile a program against OkHttp 3.x, and then to run it against OkHttp 4.x. We’re using the excellent japicmp library via its Gradle plugin to enforce binary compatibility. > https://square.github.io/okhttp/upgrading_to_okhttp_4/ * 2 test cases are updated due to OkHttp's internal field name is changed. (RestTemplateBuilderTests.java) * Also InfluxDbProperties is changed due to issue in influxdb-java. * Under OkHttp3, influxdb-java sends "Authorization: encode(null:null" * Under new version of OkHttp, null username & password not leads illegal BasicAuth configuration but throws NullPointer exception. * Anyway, if user don't use auth, nothing affected I think. This issue fixed in https://github.com/influxdata/influxdb-java/pull/644/files#diff-23360835991a654afd56314b41590521L150-R155, but not released yet.
spring-projects-issues
added
the
status: waiting-for-triage
|
Thanks for the PR, but this has already been considered and rejected. |
wilkinsona
added
status: duplicate
|
Oh, sorry i don't find it. I understand your concern. I seek forward to upgrade it (and spring boot 3.x!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First: I don't know if there are any reason to avoid upgrade OkHttp to 4.x. Sorry if I'm sending PR about already rejected topic.
According to https://square.github.io/okhttp/upgrading_to_okhttp_4/, 4.x has strict compatibility for 3.x. So upgrade to 4.x by dependency management is safer than typical major upgrade.
2 test cases are updated due to OkHttp's internal field name is changed. (RestTemplateBuilderTests.java)
Also InfluxDbProperties is changed due to issue in influxdb-java.
This issue fixed in https://github.com/influxdata/influxdb-java/pull/644/files#diff-23360835991a654afd56314b41590521L150-R155, but not released yet.