Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade group("com.squareup.okhttp3") to 4.4.1 and start using bom. #20592

Closed
wants to merge 1 commit into from
Closed

Upgrade group("com.squareup.okhttp3") to 4.4.1 and start using bom. #20592

wants to merge 1 commit into from

Commits on Mar 20, 2020

  1. Upgrade group("com.squareup.okhttp3") to 4.4.1 and start using bom. 

    * Upgrade OkHttp to 4.4.1

According to https://square.github.io/okhttp/upgrading_to_okhttp_4/, 4.x has perfect binary compatibility for 3.x
> Binary compatibility is the ability to compile a program against OkHttp 3.x, and then to run it against OkHttp 4.x. We’re using the excellent japicmp library via its Gradle plugin to enforce binary compatibility.
> https://square.github.io/okhttp/upgrading_to_okhttp_4/

* 2 test cases are updated due to OkHttp's internal field name is changed. (RestTemplateBuilderTests.java)

* Also InfluxDbProperties is changed due to issue in influxdb-java.
  * Under OkHttp3, influxdb-java sends "Authorization: encode(null:null"
  * Under new version of OkHttp, null username & password not leads illegal BasicAuth configuration but throws NullPointer exception.
  * Anyway, if user don't use auth, nothing affected I think.

This issue fixed in https://github.com/influxdata/influxdb-java/pull/644/files#diff-23360835991a654afd56314b41590521L150-R155, but not released yet.
    @kazuki-ma
    kazuki-ma committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    25118c8 View commit details
    Browse the repository at this point in the history