Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration item metadata ordering is not consistent #26230

Closed
wants to merge 3 commits into from
Closed

Configuration item metadata ordering is not consistent #26230

wants to merge 3 commits into from

Conversation

zeldigas
Copy link
Contributor

Fixes #26217

zeldigas
zeldigas commented Apr 25, 2021
View reviewed changes
.../test/java/org/springframework/boot/configurationprocessor/metadata/JsonMarshallerTests.java
@@ -82,7 +82,7 @@ void marshallOrderItems() throws IOException {
ByteArrayOutputStream outputStream = new ByteArrayOutputStream();
JsonMarshaller marshaller = new JsonMarshaller();
marshaller.write(metadata, outputStream);
String json = new String(outputStream.toByteArray());
String json = outputStream.toString();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ide suggestion to simplify statement

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 25, 2021
@snicoll snicoll mentioned this pull request Apr 25, 2021
Closed
@snicoll snicoll added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 25, 2021
@snicoll snicoll added this to the 2.3.x milestone Apr 25, 2021
@snicoll snicoll self-assigned this Apr 28, 2021
@snicoll snicoll modified the milestones: 2.3.x, 2.3.11 Apr 28, 2021
This was referenced Apr 28, 2021
Closed
Closed
snicoll pushed a commit that referenced this pull request Apr 28, 2021
@zeldigas @snicoll
Fix ordering of metadata entries
3e34b0a 
This commit provides a consistent ordering for groups that share the
same configuration property prefix.

See gh-26230
snicoll added a commit that referenced this pull request Apr 28, 2021
@snicoll
Polish "Fix ordering of metadata entries"
d610f3c 
See gh-26230
@snicoll snicoll closed this in 70079f9 Apr 28, 2021
@snicoll
Copy link
Member

snicoll commented Apr 28, 2021

@zeldigas thank you for making your first contribution to Spring Boot. I've polished things in d610f3c . In particular, the sourceType is not mandatory and that was breaking with a NPE in that case.

@snicoll snicoll changed the title Fixing ordering for multiple classes that share same configuration property Configuration item metadata ordering is not consistent Apr 28, 2021
@zeldigas
Copy link
Contributor Author

Great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuspymd cuspymd cuspymd left review comments

Assignees

@snicoll snicoll

Labels
type: bug A general bug
Projects
None yet
Milestone
2.3.11
Development

Successfully merging this pull request may close these issues.

Not fully consistent ordering in spring-configuration-metadata.json
4 participants
@zeldigas @snicoll @cuspymd @spring-projects-issues